Page MenuHomeFreeBSD
Differential D20560

Style MAP_ENTRY_ and MAP_ definitions.
ClosedPublic
Actions

Authored by kib on Jun 8 2019, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 23 2024, 1:13 AM
Unknown Object (File)
Nov 16 2024, 5:30 PM
Unknown Object (File)
Oct 19 2024, 4:27 PM
Unknown Object (File)
Oct 10 2024, 2:03 PM
Unknown Object (File)
Oct 4 2024, 11:30 PM
Unknown Object (File)
Oct 2 2024, 8:49 PM
Unknown Object (File)
Oct 2 2024, 3:34 AM
Unknown Object (File)
Sep 30 2024, 11:11 AM
View All 61 Files
Subscribers
imp

Details

Reviewers
alc
markj
dougm
Commits
rS348816: Style MAP_ENTRY_ and MAP_ definitions.
Summary

Spell all bits in the hex constants.
Since all lines are modified, consistently use <tab> after #define.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 24773

Event Timeline

kib created this revision.Jun 8 2019, 7:44 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 8 2019, 7:44 PM
Harbormaster completed remote builds in B24772: Diff 58412.Jun 8 2019, 7:44 PM
alc accepted this revision.Jun 8 2019, 8:05 PM

I only wish that the options to mmap(2) and the vm_map operations didn't use the same prefix, i.e., "MAP_". :-(

This revision is now accepted and ready to land.Jun 8 2019, 8:05 PM
dougm added inline comments.Jun 8 2019, 8:07 PM
sys/vm/vm_map.h
143

Capitalizing Top and Bottom is inconsistent with the rest.

kib updated this revision to Diff 58413.Jun 8 2019, 8:22 PM

Lowercase comments.

This revision now requires review to proceed.Jun 8 2019, 8:22 PM
Harbormaster completed remote builds in B24773: Diff 58413.Jun 8 2019, 8:22 PM
dougm accepted this revision.Jun 8 2019, 8:23 PM
This revision is now accepted and ready to land.Jun 8 2019, 8:23 PM
Closed by commit rS348816: Style MAP_ENTRY_ and MAP_ definitions. (authored by kib). · Explain WhyJun 8 2019, 8:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
vm/
96 lines

Diff 58413

View Options

sys/vm/vm_map.h

Loading...