Differential D20560

Style MAP_ENTRY_ and MAP_ definitions.
ClosedPublic
Actions

Authored by kib on Jun 8 2019, 7:44 PM.

Tags

None

Referenced Files

	F163825367: D20560.id58413.diff
	Sun, Jul 26, 10:20 AM

	Unknown Object (File)
	Sat, Jul 25, 3:07 AM

	Unknown Object (File)
	Tue, Jul 21, 6:12 AM

	Unknown Object (File)
	Sat, Jul 18, 3:48 PM

	Unknown Object (File)
	Thu, Jul 9, 4:10 PM

	Unknown Object (File)
	Fri, Jul 3, 8:42 PM

	Unknown Object (File)
	Tue, Jun 30, 2:48 PM

	Unknown Object (File)
	May 16 2026, 5:53 PM

View All Files

Subscribers

imp

Details

Reviewers

alc
markj
dougm

Commits

rS348816: Style MAP_ENTRY_ and MAP_ definitions.

Summary

Spell all bits in the hex constants.
Since all lines are modified, consistently use <tab> after #define.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 24772

Event Timeline

kib created this revision.Jun 8 2019, 7:44 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 8 2019, 7:44 PM

Harbormaster completed remote builds in B24772: Diff 58412.Jun 8 2019, 7:44 PM

I only wish that the options to mmap(2) and the vm_map operations didn't use the same prefix, i.e., "MAP_". :-(

This revision is now accepted and ready to land.Jun 8 2019, 8:05 PM

dougm added inline comments.Jun 8 2019, 8:07 PM

sys/vm/vm_map.h
143	Capitalizing Top and Bottom is inconsistent with the rest.

Lowercase comments.

This revision now requires review to proceed.Jun 8 2019, 8:22 PM

Harbormaster completed remote builds in B24773: Diff 58413.Jun 8 2019, 8:22 PM

dougm accepted this revision.Jun 8 2019, 8:23 PM

This revision is now accepted and ready to land.Jun 8 2019, 8:23 PM

Closed by commit rS348816: Style MAP_ENTRY_ and MAP_ definitions. (authored by kib). · Explain WhyJun 8 2019, 8:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_map.h

96 lines

Diff 58412

View Options

Style MAP_ENTRY_ and MAP_ definitions.ClosedPublicActions