Differential D20553

[PPC64] Fix ofw_initrd
ClosedPublic
Actions

Authored by luporl on Jun 7 2019, 5:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 9, 7:39 PM

	Unknown Object (File)
	Sun, Dec 28, 3:18 AM

	Unknown Object (File)
	Dec 19 2025, 3:31 PM

	Unknown Object (File)
	Dec 9 2025, 10:34 PM

	Unknown Object (File)
	Nov 26 2025, 11:38 PM

	Unknown Object (File)
	Nov 21 2025, 12:44 AM

	Unknown Object (File)
	Nov 21 2025, 12:42 AM

	Unknown Object (File)
	Nov 21 2025, 12:41 AM

Subscribers

gromero_br.ibm.com

Details

Reviewers

Commits

rS348899: [PPC64] Fix ofw_initrd

Summary

Before this change, OFW initrd (as md) handling code was simulating an
ofwbus device. But as there isn't really a Device Tree (DT) node
representing OFW initrd (it is specified in 2 properties under
/chosen), its driver was in fact stealing other driver's DT node.
This was noticed after MD_ROOT_MEM became default and QEMU's USB
keyboard stopped working under VNC.

This change consists in simplifying the process of detection and mapping of initrd memory,
turning it into a simple startup step, instead of trying to simulate a device.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24757
Build 23518: arc lint + arc unit

Event Timeline

luporl created this revision.Jun 7 2019, 5:14 PM

Harbormaster completed remote builds in B24757: Diff 58372.Jun 7 2019, 5:15 PM

Good catch. We should probably consider adding !hw_direct_map support sometime in the future, too, for use in Qemu/KVM.

This revision is now accepted and ready to land.Jun 7 2019, 6:24 PM

Closed by commit rS348899: [PPC64] Fix ofw_initrd (authored by luporl). · Explain WhyJun 11 2019, 11:17 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 11 2019, 11:17 AM

dmitry_kernelgen.org mentioned this in D39164: [ARM64] Provided initrd in "linux,initrd-start" and "linux,initrd-end" props of FDT /chosen node, mount it as an in-memory startup disk (mfsroot)..Mar 18 2023, 10:36 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

ofw/

101 lines

Diff 58372

sys/powerpc/ofw/ofw_initrd.c

Loading...