Page MenuHomeFreeBSD
Differential D20503

Remove the header comment in vm_page.c.
ClosedPublic
Actions

Authored by markj on Jun 3 2019, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 29, 7:16 PM
Unknown Object (File)
Sun, Dec 28, 9:05 PM
Unknown Object (File)
Fri, Dec 19, 6:00 AM
Unknown Object (File)
Fri, Dec 19, 6:00 AM
Unknown Object (File)
Fri, Dec 19, 6:00 AM
Unknown Object (File)
Thu, Dec 11, 1:45 AM
Unknown Object (File)
Nov 26 2025, 6:50 PM
Unknown Object (File)
Nov 20 2025, 9:43 PM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rS348660: Remove an outdated header comment for vm_page.c.
Summary

It is outdated, and there is a much more thorough comment in vm_page.h.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24666
Build 23439: arc lint + arc unit

Event Timeline

markj created this revision.Jun 3 2019, 3:34 PM
Harbormaster completed remote builds in B24664: Diff 58193.Jun 3 2019, 3:34 PM
markj added reviewers: alc, kib.Jun 3 2019, 3:34 PM
kib accepted this revision.Jun 3 2019, 4:24 PM
This revision is now accepted and ready to land.Jun 3 2019, 4:24 PM
alc added inline comments.Jun 3 2019, 5:07 PM
sys/vm/vm_page.c
82–84

I'm fine with deleting the GENERAL RULES ON VM_PAGE MANIPULATION comment as stale.

However, there are similar one-line comments to "Resident memory management module." at the start of other files that we inherited from Mach. If you're going to delete one, please delete them all.

markj updated this revision to Diff 58198.Jun 3 2019, 5:25 PM

Restore the "Resident memory management module" comment.

This revision now requires review to proceed.Jun 3 2019, 5:25 PM
Harbormaster completed remote builds in B24666: Diff 58198.Jun 3 2019, 5:25 PM
alc accepted this revision.Jun 3 2019, 7:10 PM
This revision is now accepted and ready to land.Jun 3 2019, 7:10 PM
kib accepted this revision.Jun 3 2019, 7:21 PM
Closed by commit rS348660: Remove an outdated header comment for vm_page.c. (authored by markj). · Explain WhyJun 4 2019, 6:38 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJun 4 2019, 6:38 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
17 lines

Diff 58198

View Options

sys/vm/vm_page.c

Loading...