Page MenuHomeFreeBSD
Differential D20485

Use the vm_page_wired() predicate where appropriate.
ClosedPublic
Actions

Authored by markj on May 31 2019, 8:45 PM.
Tags
None
Referenced Files
F161696630: D20485.diff
Mon, Jul 6, 1:03 AM
F161677013: D20485.id58127.diff
Sun, Jul 5, 9:07 PM
Unknown Object (File)
Sun, Jul 5, 5:39 AM
Unknown Object (File)
Sat, Jul 4, 9:15 AM
Unknown Object (File)
Sat, Jul 4, 2:48 AM
Unknown Object (File)
Thu, Jul 2, 11:47 PM
Unknown Object (File)
Thu, Jul 2, 10:39 PM
Unknown Object (File)
Wed, Jul 1, 5:24 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
jeff
Commits
rS348502: Add a vm_page_wired() predicate.
Summary

This is a follow-up for D19247. I would like to minimize naked accesses to wire_count
as much as possible, since D20486 makes use of several bits in that field to
store special references.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 31 2019, 8:45 PM
Harbormaster completed remote builds in B24634: Diff 58127.May 31 2019, 8:45 PM
markj added a parent revision: D19247: Merge hold_count into wire_count..May 31 2019, 9:20 PM
markj added a child revision: D20486: Change synchonization rules for page reference counting..
markj mentioned this in D19247: Merge hold_count into wire_count..May 31 2019, 9:25 PM
markj edited the summary of this revision. (Show Details)
markj added reviewers: alc, kib, jeff.
alc added a comment.Jun 1 2019, 4:21 AM

Where is vm_page_wired() defined?

markj added a comment.Jun 1 2019, 2:54 PM
In D20485#442354, @alc wrote:

Where is vm_page_wired() defined?

In D19247, I renamed it from vm_page_held().

alc accepted this revision.Jun 1 2019, 4:19 PM
In D20485#442381, @markj wrote:
In D20485#442354, @alc wrote:

Where is vm_page_wired() defined?

In D19247, I renamed it from vm_page_held().

Okay.

This revision is now accepted and ready to land.Jun 1 2019, 4:19 PM
kib added a comment.Jun 1 2019, 5:47 PM

Could you please update the diff to include the definition if vm_page_wired() ? I expect it to be trivial.

markj updated this revision to Diff 58162.Jun 1 2019, 9:43 PM

Add a vm_page_wired() definition and rebase on FreeBSD head
instead of D19247.

This revision now requires review to proceed.Jun 1 2019, 9:43 PM
Harbormaster completed remote builds in B24650: Diff 58162.Jun 1 2019, 9:43 PM
markj added a comment.Jun 1 2019, 9:43 PM
In D20485#442437, @kib wrote:

Could you please update the diff to include the definition if vm_page_wired() ? I expect it to be trivial.

I rebased the change so that it does not depend on the hold/wire count merge diff. Once this diff is committed, I will rebase that diff.

alc accepted this revision.Jun 1 2019, 9:59 PM
This revision is now accepted and ready to land.Jun 1 2019, 9:59 PM
kib accepted this revision.Jun 1 2019, 10:18 PM
Closed by commit rS348502: Add a vm_page_wired() predicate. (authored by markj). · Explain WhyJun 2 2019, 1:00 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJun 2 2019, 1:00 AM

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
4 lines
2 lines
6 lines
8 lines
7 lines
18 lines
6 lines

Diff 58169

View Options

head/sys/vm/memguard.c

Loading...
View Options

head/sys/vm/swap_pager.c

Loading...
View Options

head/sys/vm/vm_fault.c

Loading...
View Options

head/sys/vm/vm_object.c

Loading...
View Options

head/sys/vm/vm_page.h

Loading...
View Options

head/sys/vm/vm_page.c

Loading...
View Options

head/sys/vm/vm_pageout.c

Loading...