Page MenuHomeFreeBSD

Use the vm_page_wired() predicate where appropriate.
ClosedPublic

Authored by markj on May 31 2019, 8:45 PM.

Details

Summary

This is a follow-up for D19247. I would like to minimize naked accesses to wire_count
as much as possible, since D20486 makes use of several bits in that field to
store special references.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.May 31 2019, 8:45 PM
markj edited the summary of this revision. (Show Details)
markj added reviewers: alc, kib, jeff.
alc added a comment.Jun 1 2019, 4:21 AM

Where is vm_page_wired() defined?

markj added a comment.Jun 1 2019, 2:54 PM
In D20485#442354, @alc wrote:

Where is vm_page_wired() defined?

In D19247, I renamed it from vm_page_held().

alc accepted this revision.Jun 1 2019, 4:19 PM
In D20485#442354, @alc wrote:

Where is vm_page_wired() defined?

In D19247, I renamed it from vm_page_held().

Okay.

This revision is now accepted and ready to land.Jun 1 2019, 4:19 PM
kib added a comment.Jun 1 2019, 5:47 PM

Could you please update the diff to include the definition if vm_page_wired() ? I expect it to be trivial.

markj updated this revision to Diff 58162.Jun 1 2019, 9:43 PM

Add a vm_page_wired() definition and rebase on FreeBSD head
instead of D19247.

This revision now requires review to proceed.Jun 1 2019, 9:43 PM
markj added a comment.Jun 1 2019, 9:43 PM
In D20485#442437, @kib wrote:

Could you please update the diff to include the definition if vm_page_wired() ? I expect it to be trivial.

I rebased the change so that it does not depend on the hold/wire count merge diff. Once this diff is committed, I will rebase that diff.

alc accepted this revision.Jun 1 2019, 9:59 PM
This revision is now accepted and ready to land.Jun 1 2019, 9:59 PM
kib accepted this revision.Jun 1 2019, 10:18 PM
This revision was automatically updated to reflect the committed changes.