Page MenuHomeFreeBSD
Differential D20480

Defer evaluation of modified until after it's set
ClosedPublic
Actions

Authored by imp on May 31 2019, 3:01 PM.
Tags
None
Referenced Files
F103327599: D20480.diff
Sat, Nov 23, 2:49 PM
Unknown Object (File)
Thu, Nov 21, 3:34 PM
Unknown Object (File)
Thu, Nov 21, 1:38 PM
Unknown Object (File)
Thu, Nov 21, 3:46 AM
Unknown Object (File)
Mon, Nov 18, 9:54 AM
Unknown Object (File)
Mon, Nov 18, 3:27 AM
Unknown Object (File)
Sun, Nov 17, 4:05 PM
Unknown Object (File)
Sun, Nov 17, 9:46 AM
View All 78 Files
Subscribers
None

Details

Reviewers
emaste
zeising
Commits
rS348486: Defer evaluation of modified until after it's set
Summary

With the reorg r348175, we now look at modified before it is
set. Rearrange things so that we can set include_metadata to either
yes, no or some variable to be evaluated in the future (in this case
modified). Use the eval echo trick to expanded it. This should fix the
-R flag that was broken in r348175, which broke
WITH_REPRODUCIBLE_BUILD for kernels.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24635
Build 23413: arc lint + arc unit

Event Timeline

imp created this revision.May 31 2019, 3:01 PM
Harbormaster completed remote builds in B24621: Diff 58112.May 31 2019, 3:01 PM
imp added reviewers: emaste, zeising.May 31 2019, 3:12 PM
emaste added a comment.May 31 2019, 4:59 PM

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]

Anyway if you prefer this approach that's fine with me

imp updated this revision to Diff 58128.May 31 2019, 8:53 PM

Fix per ed (though a little different construct)
Fix backwards test after converting from -z notation...

Harbormaster completed remote builds in B24635: Diff 58128.May 31 2019, 8:53 PM
imp added a comment.May 31 2019, 9:03 PM
In D20480#442157, @emaste wrote:

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]

Anyway if you prefer this approach that's fine with me

Due to the funky way that test works, I opted for a slightly different way to say this...

This revision was not accepted when it landed; it landed in state Needs Review.May 31 2019, 10:57 PM
Closed by commit rS348486: Defer evaluation of modified until after it's set (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
conf/
18 lines

Diff 58128

View Options

sys/conf/newvers.sh

Loading...