Page MenuHomeFreeBSD

Defer evaluation of modified until after it's set
ClosedPublic

Authored by imp on May 31 2019, 3:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 1:11 AM
Unknown Object (File)
Fri, May 3, 12:32 AM
Unknown Object (File)
Fri, May 3, 12:31 AM
Unknown Object (File)
Thu, May 2, 9:30 PM
Unknown Object (File)
Thu, May 2, 8:08 PM
Unknown Object (File)
Fri, Apr 26, 3:20 AM
Unknown Object (File)
Mar 11 2024, 5:59 AM
Unknown Object (File)
Mar 11 2024, 5:59 AM
Subscribers
None

Details

Summary

With the reorg r348175, we now look at modified before it is
set. Rearrange things so that we can set include_metadata to either
yes, no or some variable to be evaluated in the future (in this case
modified). Use the eval echo trick to expanded it. This should fix the
-R flag that was broken in r348175, which broke
WITH_REPRODUCIBLE_BUILD for kernels.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24621
Build 23402: arc lint + arc unit

Event Timeline

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]

Anyway if you prefer this approach that's fine with me

Fix per ed (though a little different construct)
Fix backwards test after converting from -z notation...

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]

Anyway if you prefer this approach that's fine with me

Due to the funky way that test works, I opted for a slightly different way to say this...

This revision was not accepted when it landed; it landed in state Needs Review.May 31 2019, 10:57 PM
This revision was automatically updated to reflect the committed changes.