Page MenuHomeFreeBSD

Defer evaluation of modified until after it's set
ClosedPublic

Authored by imp on May 31 2019, 3:01 PM.

Details

Summary

With the reorg r348175, we now look at modified before it is
set. Rearrange things so that we can set include_metadata to either
yes, no or some variable to be evaluated in the future (in this case
modified). Use the eval echo trick to expanded it. This should fix the
-R flag that was broken in r348175, which broke
WITH_REPRODUCIBLE_BUILD for kernels.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.May 31 2019, 3:01 PM

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]

Anyway if you prefer this approach that's fine with me

imp updated this revision to Diff 58128.May 31 2019, 8:53 PM

Fix per ed (though a little different construct)
Fix backwards test after converting from -z notation...

imp added a comment.May 31 2019, 9:03 PM

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]
Anyway if you prefer this approach that's fine with me

Due to the funky way that test works, I opted for a slightly different way to say this...

This revision was not accepted when it landed; it landed in state Needs Review.May 31 2019, 10:57 PM
This revision was automatically updated to reflect the committed changes.