Page MenuHomeFreeBSD
Differential D20363

DTrace: fix reading a 64-bits register on amd64
ClosedPublic
Actions

Authored by oshogbo on May 22 2019, 7:48 PM.
Tags
None
Referenced Files
F170138505: D20363.diff
Thu, Sep 3, 3:18 PM
F170130905: D20363.diff
Thu, Sep 3, 2:50 PM
Unknown Object (File)
Tue, Sep 1, 11:44 PM
Unknown Object (File)
Tue, Sep 1, 9:36 PM
Unknown Object (File)
Tue, Sep 1, 5:25 PM
Unknown Object (File)
Tue, Sep 1, 2:31 PM
Unknown Object (File)
Sun, Aug 30, 3:30 PM
Unknown Object (File)
Sun, Aug 30, 3:30 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
markj
gnn
Commits
rS348705: dtrace: 64-bits registers support
Summary

The registers in ilumos and FreeBSD have a different number.
In the illumos, last 32-bits register defined is SS an in FreeBSD is GS.
This off-by-one caused the uregs array to returns the wrong 64-bits register
on amd64.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24407
Build 23223: arc lint + arc unit

Event Timeline

oshogbo created this revision.May 22 2019, 7:48 PM
Harbormaster completed remote builds in B24407: Diff 57718.May 22 2019, 7:48 PM
oshogbo added reviewers: emaste, markj, gnn.May 22 2019, 7:48 PM
markj accepted this revision.May 22 2019, 9:10 PM
markj added inline comments.
sys/cddl/dev/dtrace/amd64/dtrace_isa.c
519

I wouldn't bother with the comment in such a small block.

This revision is now accepted and ready to land.May 22 2019, 9:10 PM
Closed by commit rS348705: dtrace: 64-bits registers support (authored by oshogbo). · Explain WhyJun 5 2019, 10:29 PM
This revision was automatically updated to reflect the committed changes.
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJun 5 2019, 10:29 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
dtrace/
amd64/
4 lines

Diff 57718

View Options

sys/cddl/dev/dtrace/amd64/dtrace_isa.c

Loading...