Page MenuHomeFreeBSD

net/dpdk: Fix build after r347984
ClosedPublic

Authored by cem on May 21 2019, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 6:16 PM
Unknown Object (File)
Fri, Mar 22, 6:16 PM
Unknown Object (File)
Fri, Mar 22, 6:16 PM
Unknown Object (File)
Fri, Mar 22, 6:16 PM
Unknown Object (File)
Fri, Mar 22, 6:16 PM
Unknown Object (File)
Sun, Mar 10, 4:51 AM
Unknown Object (File)
Feb 21 2024, 5:29 PM
Unknown Object (File)
Jan 15 2024, 4:00 PM
Subscribers

Details

Reviewers
None
Group Reviewers
Ports Committers
Commits
rP502275: net/dpdk: Fix build after r347984
Summary

Address missing implicit includes removed as a header pollution cleanup in
r347984. Apologies that this wasn't addressed in advance; my spot check ahead
of time seems to have been against the wrong kernel source tree. I will submit
the same changes to upstream dpdk.

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24346
Build 23168: arc lint + arc unit

Event Timeline

Now with patches 'svn add'ed

Need ports committer blessing to fix.

Are those build fixes or runtime fixes ? Because if they are build fixes, you do not need to bump PORTREVISION as their is no previous package of that version.

In D20329#438359, @mat wrote:

Are those build fixes or runtime fixes ? Because if they are build fixes, you do not need to bump PORTREVISION as their is no previous package of that version.

Build. There is no package either way; this port has NO_PACKAGE set.

So please remove the PORTREVISION bump.

(NO_PACKAGE does not do what you think it does.)

In D20329#438578, @mat wrote:

So please remove the PORTREVISION bump.

Ok.

(NO_PACKAGE does not do what you think it does.)

Can you elaborate? What does it do, and why do you think that's different from what I think?

$ make -C net/dpdk package
===>  dpdk-18.05.1 may not be packaged: ignores cflags.
In D20329#438589, @cem wrote:
In D20329#438578, @mat wrote:

(NO_PACKAGE does not do what you think it does.)

Can you elaborate? What does it do, and why do you think that's different from what I think?

$ make -C net/dpdk package
===>  dpdk-18.05.1 may not be packaged: ignores cflags.

A package is always generated, because it is what is used to install the port. NO_PACKAGE is the old deprecated way to say that a package should not be distributed.

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2019, 5:34 PM
This revision was automatically updated to reflect the committed changes.