Page MenuHomeFreeBSD

net/dpdk: Fix build after r347984
ClosedPublic

Authored by cem on May 21 2019, 1:45 AM.

Details

Reviewers
None
Group Reviewers
Ports Committers
Commits
rP502275: net/dpdk: Fix build after r347984
Summary

Address missing implicit includes removed as a header pollution cleanup in
r347984. Apologies that this wasn't addressed in advance; my spot check ahead
of time seems to have been against the wrong kernel source tree. I will submit
the same changes to upstream dpdk.

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem created this revision.May 21 2019, 1:45 AM
cem updated this revision to Diff 57616.May 21 2019, 1:46 AM

Now with patches 'svn add'ed

Need ports committer blessing to fix.

cem edited the test plan for this revision. (Show Details)May 21 2019, 1:55 AM
mat added a comment.May 21 2019, 7:31 AM

Are those build fixes or runtime fixes ? Because if they are build fixes, you do not need to bump PORTREVISION as their is no previous package of that version.

cem added a comment.May 21 2019, 4:29 PM
In D20329#438359, @mat wrote:

Are those build fixes or runtime fixes ? Because if they are build fixes, you do not need to bump PORTREVISION as their is no previous package of that version.

Build. There is no package either way; this port has NO_PACKAGE set.

mat added a comment.May 21 2019, 9:26 PM

So please remove the PORTREVISION bump.

(NO_PACKAGE does not do what you think it does.)

cem added a comment.May 21 2019, 9:38 PM
In D20329#438578, @mat wrote:

So please remove the PORTREVISION bump.

Ok.

(NO_PACKAGE does not do what you think it does.)

Can you elaborate? What does it do, and why do you think that's different from what I think?

$ make -C net/dpdk package
===>  dpdk-18.05.1 may not be packaged: ignores cflags.
cem updated this revision to Diff 57651.May 21 2019, 9:39 PM

Remove PORTREVISION

Harbormaster completed remote builds in B24367: Diff 57651.
mat added a comment.May 22 2019, 7:23 AM
In D20329#438589, @cem wrote:
In D20329#438578, @mat wrote:

(NO_PACKAGE does not do what you think it does.)

Can you elaborate? What does it do, and why do you think that's different from what I think?

$ make -C net/dpdk package
===>  dpdk-18.05.1 may not be packaged: ignores cflags.

A package is always generated, because it is what is used to install the port. NO_PACKAGE is the old deprecated way to say that a package should not be distributed.

mat accepted this revision as: Ports Committers.May 22 2019, 7:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 22 2019, 5:34 PM
This revision was automatically updated to reflect the committed changes.