Page MenuHomeFreeBSD
Differential D20189

[new port] devel/git-subrepo, a Git command for managing subrepositories.
ClosedPublic
Actions

Authored by jhb on May 7 2019, 11:29 PM.
Tags
None
Referenced Files
F163256993: D20189.id57149.diff
Tue, Jul 21, 12:04 PM
Unknown Object (File)
Sun, Jul 19, 3:53 AM
Unknown Object (File)
Fri, Jul 10, 8:18 PM
Unknown Object (File)
Sat, Jul 4, 4:35 AM
Unknown Object (File)
Thu, Jul 2, 4:50 PM
Unknown Object (File)
Thu, Jul 2, 2:19 PM
Unknown Object (File)
Thu, Jul 2, 1:25 PM
Unknown Object (File)
Mon, Jun 29, 3:55 PM
View All Files
Subscribers
mat

Details

Reviewers
brooks
arichardson
Commits
rP502170: New port: devel/git-subrepo: Git command for managing subrepositories
Test Plan
  • portlint -a
  • poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.May 7 2019, 11:29 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 7 2019, 11:29 PM
Harbormaster completed remote builds in B24141: Diff 57149.May 7 2019, 11:29 PM
brooks accepted this revision.May 7 2019, 11:31 PM

LGTM

This revision is now accepted and ready to land.May 7 2019, 11:31 PM
linimon retitled this revision from Add git-subrepo, a Git command for managing subrepositories. to [new port] devel/git-subrepo, a Git command for managing subrepositories..May 8 2019, 2:49 AM
mat added inline comments.May 8 2019, 9:39 AM
devel/git-subrepo/Makefile
24 ↗(On Diff #57149)

This is never used.

26 ↗(On Diff #57149)

Why +=?

jhb updated this revision to Diff 57186.May 8 2019, 4:15 PM

Fix two nits mat@ noticed.

This revision now requires review to proceed.May 8 2019, 4:15 PM
Harbormaster completed remote builds in B24157: Diff 57186.May 8 2019, 4:15 PM
jhb marked 2 inline comments as done.May 8 2019, 4:16 PM
jhb added inline comments.
devel/git-subrepo/Makefile
24 ↗(On Diff #57149)

Oops, leftover from earlier testing.

jhb marked an inline comment as done.May 8 2019, 4:17 PM
jhb added a comment.May 20 2019, 6:29 PM

bdrewery looked this over and approved it in person during a break in between talks at BSDCan

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2019, 9:04 PM
Closed by commit rP502170: New port: devel/git-subrepo: Git command for managing subrepositories (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
devel/
1 line
git-subrepo/
26 lines
3 lines
5 lines
4 lines

Diff 57606

View Options

head/devel/Makefile

Loading...
View Options

head/devel/git-subrepo/Makefile

Loading...
View Options

head/devel/git-subrepo/distinfo

Loading...
View Options

head/devel/git-subrepo/pkg-descr

Loading...
View Options

head/devel/git-subrepo/pkg-plist

Loading...