Page MenuHomeFreeBSD
Differential D20189

[new port] devel/git-subrepo, a Git command for managing subrepositories.
ClosedPublic
Actions

Authored by jhb on May 7 2019, 11:29 PM.
Tags
None
Referenced Files
F109821399: D20189.diff
Sun, Feb 9, 11:36 PM
Unknown Object (File)
Fri, Jan 31, 10:49 PM
Unknown Object (File)
Wed, Jan 22, 2:34 PM
Unknown Object (File)
Tue, Jan 21, 4:22 PM
Unknown Object (File)
Dec 4 2024, 1:05 AM
Unknown Object (File)
Nov 13 2024, 6:24 PM
Unknown Object (File)
Nov 7 2024, 1:35 AM
Unknown Object (File)
Nov 5 2024, 6:55 PM
View All 46 Files
Subscribers
mat

Details

Reviewers
brooks
arichardson
Commits
rP502170: New port: devel/git-subrepo: Git command for managing subrepositories
Test Plan
  • portlint -a
  • poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24157
Build 23006: arc lint + arc unit

Event Timeline

jhb created this revision.May 7 2019, 11:29 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 7 2019, 11:29 PM
Harbormaster completed remote builds in B24141: Diff 57149.May 7 2019, 11:29 PM
brooks accepted this revision.May 7 2019, 11:31 PM

LGTM

This revision is now accepted and ready to land.May 7 2019, 11:31 PM
linimon retitled this revision from Add git-subrepo, a Git command for managing subrepositories. to [new port] devel/git-subrepo, a Git command for managing subrepositories..May 8 2019, 2:49 AM
mat added inline comments.May 8 2019, 9:39 AM
devel/git-subrepo/Makefile
25

This is never used.

27

Why +=?

jhb updated this revision to Diff 57186.May 8 2019, 4:15 PM

Fix two nits mat@ noticed.

This revision now requires review to proceed.May 8 2019, 4:15 PM
Harbormaster completed remote builds in B24157: Diff 57186.May 8 2019, 4:15 PM
jhb marked 2 inline comments as done.May 8 2019, 4:16 PM
jhb added inline comments.
devel/git-subrepo/Makefile
25

Oops, leftover from earlier testing.

jhb marked an inline comment as done.May 8 2019, 4:17 PM
jhb added a comment.May 20 2019, 6:29 PM

bdrewery looked this over and approved it in person during a break in between talks at BSDCan

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2019, 9:04 PM
Closed by commit rP502170: New port: devel/git-subrepo: Git command for managing subrepositories (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
1 line
26 lines
3 lines
5 lines
4 lines

Diff 57186

View Options

devel/Makefile

Loading...
View Options

devel/git-subrepo/

Loading...
View Options

devel/git-subrepo/Makefile

Loading...
View Options

devel/git-subrepo/distinfo

Loading...
View Options

devel/git-subrepo/pkg-descr

Loading...
View Options

devel/git-subrepo/pkg-plist

Loading...