Tags

None

Referenced Files

	F101330434: D20226.diff
	Sun, Oct 27, 10:35 PM

	Unknown Object (File)
	Thu, Oct 24, 1:35 PM

	Unknown Object (File)
	Thu, Oct 24, 1:17 PM

	Unknown Object (File)
	Thu, Oct 24, 11:58 AM

	Unknown Object (File)
	Thu, Oct 24, 8:59 AM

	Unknown Object (File)
	Thu, Oct 24, 8:20 AM

	Unknown Object (File)
	Thu, Oct 24, 7:52 AM

	Unknown Object (File)
	Wed, Oct 23, 8:38 AM

View All 66 Files

Subscribers

imp

Details

Reviewers

kib
markj

Commits

rS347461: Replace panic() with KASSERT() and provide more useful information when failure…

Summary

Replace panic() with KASSERT() and provide more useful information when failure happens.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm created this revision.May 10 2019, 3:41 PM

markj added inline comments.May 10 2019, 3:49 PM

subr_blist.c
123	Did you consider using assert(3)?
289–290	Style: extra space after KASSERT.

Remove extra space.

subr_blist.c
123	The change from panic to KASSERT was driven entirely by my other mentor. I considered nothing.

kib added inline comments.May 10 2019, 4:09 PM

subr_blist.c
290	What is maxcount ?
334	We ise %jx and uintmax_t for such cases. It is probably fine to cast count to int, but if the value is corrupted, it would hide the information by truncating.

Replace maxcount with count, %llx with %jx, and (long long) with (uintmax_t).

kib added inline comments.May 10 2019, 5:10 PM

subr_blist.c
123	Mark means that you can implement KASSERT using assert(3), he does not suggest to use assert instead of KASSERT.

Use assert() for KASSERT in the blist test program.

kib accepted this revision.May 10 2019, 5:51 PM

This revision is now accepted and ready to land.May 10 2019, 5:51 PM

Closed by commit rS347461: Replace panic() with KASSERT() and provide more useful information when failure… (authored by dougm). · Explain WhyMay 10 2019, 6:22 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2019, 6:22 PM

Replace panic() with KASSERT in subr_blist.c
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 57270

subr_blist.c

Replace panic() with KASSERT in subr_blist.cClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 57270

subr_blist.c

Replace panic() with KASSERT in subr_blist.c
ClosedPublic
Actions

Revision Contents
Changeset List