Replace panic() with KASSERT in subr_blist.c

[dougm]

Summary

Replace panic() with KASSERT() and provide more useful information when failure happens.

[markj]

subr_blist.c

123 ↗

(On Diff #57265)

Did you consider using assert(3)?

289 ↗

(On Diff #57265)

Style: extra space after KASSERT.

[dougm]

Remove extra space.

subr_blist.c

123 ↗

(On Diff #57265)

The change from panic to KASSERT was driven entirely by my other mentor. I considered nothing.

[kib]

subr_blist.c

290 ↗

(On Diff #57269)

What is maxcount ?

334 ↗

(On Diff #57269)

We ise %jx and uintmax_t for such cases. It is probably fine to cast count to int, but if the value is corrupted, it would hide the information by truncating.

[dougm]

Replace maxcount with count, %llx with %jx, and (long long) with (uintmax_t).

[kib]

subr_blist.c

123 ↗

(On Diff #57265)

Mark means that you can implement KASSERT using assert(3), he does not suggest to use assert instead of KASSERT.

[dougm]

Use assert() for KASSERT in the blist test program.