Differential D20122

Use D_PARTISGPT rather than bare 255
ClosedPublic
Actions

Authored by imp on May 1 2019, 5:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 7:36 AM

	Unknown Object (File)
	Sat, Sep 5, 4:47 AM

	Unknown Object (File)
	Fri, Sep 4, 11:57 PM

	Unknown Object (File)
	Thu, Sep 3, 5:40 AM

	Unknown Object (File)
	Thu, Sep 3, 3:36 AM

	Unknown Object (File)
	Wed, Sep 2, 7:46 PM

	Unknown Object (File)
	Wed, Sep 2, 5:11 PM

	Unknown Object (File)
	Wed, Sep 2, 7:50 AM

View All Files

Subscribers

None

Details

Reviewers

tsoome
• ian
kevans
bcran

Commits

rS346984: Use D_PARTISGPT rather than bare 255

Summary

These three cases dovetail with other places in the code where we use
or set D_PARTISGPT when we mean that the partitioning scheme is
GPT. Use this #define to make the code easier to undertand.

NOTE: My reading of grep -r 255 src/stand says I caught them all. Prove me wrong.

Bonus question: Do we use a different #define that happens to be 255 when we mean this one. I don't think so.

Test Plan

md5 says the .o is the same before and afer :).

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24031
Build 22917: arc lint + arc unit

Event Timeline

imp created this revision.May 1 2019, 5:33 AM

Harbormaster completed remote builds in B24031: Diff 56899.May 1 2019, 5:33 AM

imp added reviewers: tsoome, • ian, kevans, bcran.May 1 2019, 5:34 AM

LGTM

This revision is now accepted and ready to land.May 1 2019, 5:35 AM

imp edited the summary of this revision. (Show Details)May 1 2019, 5:36 AM

Closed by commit rS346984: Use D_PARTISGPT rather than bare 255 (authored by imp). · Explain WhyMay 1 2019, 5:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

stand/

common/

disk.c

6 lines

Diff 56899

View Options

Use D_PARTISGPT rather than bare 255ClosedPublicActions