Page MenuHomeFreeBSD

[PPC64] Fix wrong KASSERT in mphyp_pte_insert()
ClosedPublic

Authored by luporl on Apr 22 2019, 5:29 PM.
Tags
None
Referenced Files
F175624525: D20012.diff
Mon, Oct 12, 3:16 AM
F175624249: D20012.id56546.diff
Mon, Oct 12, 3:14 AM
Unknown Object (File)
Mon, Sep 28, 6:59 AM
Unknown Object (File)
Fri, Sep 18, 5:04 PM
Unknown Object (File)
Thu, Sep 17, 4:15 PM
Unknown Object (File)
Tue, Sep 15, 9:49 AM
Unknown Object (File)
Sep 9 2026, 8:54 PM
Unknown Object (File)
Sep 9 2026, 4:36 PM

Details

Summary

As mphyp_pte_unset() can also remove PTE entries, and as this can
happen in parallel with PTEs evicted by mphyp_pte_insert(), there
is a (rare) chance the PTE being evicted gets removed before
mphyp_pte_insert() is able to do so. Thus, the KASSERT should
check wether the result is H_SUCCESS or H_NOT_FOUND, to avoid
panics if the situation described above occurs.

More details about this issue can be found in PR 237470.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23824
Build 22764: arc lint + arc unit