Page MenuHomeFreeBSD
Differential D19892

Mk/Uses/go.mk: Better ARM support
ClosedPublic
Actions

Authored by dmgk on Apr 12 2019, 8:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 11, 3:40 PM
Unknown Object (File)
Wed, Jul 8, 12:13 AM
Unknown Object (File)
Sat, Jul 4, 8:57 PM
Unknown Object (File)
Sat, Jul 4, 1:00 PM
Unknown Object (File)
Sat, Jul 4, 8:37 AM
Unknown Object (File)
Fri, Jul 3, 10:09 PM
Unknown Object (File)
Fri, Jul 3, 1:20 AM
Unknown Object (File)
Thu, Jul 2, 10:53 PM
View All Files
Subscribers
mat
Contributor Reviewers (ports)

Details

Reviewers
jlaffaye
swills
tobik
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP499862: Improve support for ARM in go.mk
Summary

This is a companion patch for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221297

  • If not set explicitly by the port, set CGO_ENABLED=1. CGO_ENABLED already defaults to 1 on all supported archs except ARM [1], so this change effectively just enables it on ARM.
  • If not set explicitly by the port, set GOARM from ARCH for ARM archs.

[1] https://github.com/golang/go/blob/master/src/cmd/dist/build.go#L1486

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23646
Build 22628: arc lint + arc unit

Event Timeline

dmgk created this revision.Apr 12 2019, 8:15 PM
Owners added a reviewer: O5: Ports Framework.Apr 12 2019, 8:15 PM
Herald added a reviewer: portmgr. · View Herald TranscriptApr 12 2019, 8:15 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald Transcript
Harbormaster completed remote builds in B23646: Diff 56144.Apr 12 2019, 8:15 PM
dmgk added reviewers: jlaffaye, swills.Apr 12 2019, 8:17 PM
dmgk added a reviewer: tobik.Apr 12 2019, 9:57 PM
jlaffaye accepted this revision.Apr 13 2019, 9:27 AM

LGTM, but do we know the reason why CGO is not enabled on arm by default by upstream ?

dmgk added a comment.Apr 14 2019, 12:24 PM
In D19892#427423, @jlaffaye wrote:

LGTM, but do we know the reason why CGO is not enabled on arm by default by upstream ?

I asked in the PR - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221297#c27. I also think it is just an upstream oversight at this point.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 24 2019, 4:26 PM
Closed by commit rP499862: Improve support for ARM in go.mk (authored by jlaffaye). · Explain Why
This revision was automatically updated to reflect the committed changes.
jlaffaye mentioned this in rP499862: Improve support for ARM in go.mk.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
10 lines

Diff 56144

View Options

Mk/Uses/go.mk

Loading...