Page MenuHomeFreeBSD

Mk/Uses/go.mk: Better ARM support
ClosedPublic

Authored by dmgk on Apr 12 2019, 8:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 20 2024, 11:18 PM
Unknown Object (File)
Jan 10 2024, 12:22 PM
Unknown Object (File)
Dec 21 2023, 11:44 AM
Unknown Object (File)
Dec 20 2023, 8:06 AM
Unknown Object (File)
Sep 25 2023, 3:11 PM
Unknown Object (File)
Aug 16 2023, 12:04 PM
Unknown Object (File)
Aug 5 2023, 2:51 PM
Unknown Object (File)
Jun 24 2023, 6:33 AM

Details

Reviewers
jlaffaye
swills
tobik
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP499862: Improve support for ARM in go.mk
Summary

This is a companion patch for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221297

  • If not set explicitly by the port, set CGO_ENABLED=1. CGO_ENABLED already defaults to 1 on all supported archs except ARM [1], so this change effectively just enables it on ARM.
  • If not set explicitly by the port, set GOARM from ARCH for ARM archs.

[1] https://github.com/golang/go/blob/master/src/cmd/dist/build.go#L1486

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23646
Build 22628: arc lint + arc unit

Event Timeline

LGTM, but do we know the reason why CGO is not enabled on arm by default by upstream ?

LGTM, but do we know the reason why CGO is not enabled on arm by default by upstream ?

I asked in the PR - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221297#c27. I also think it is just an upstream oversight at this point.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 24 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.