Page MenuHomeFreeBSD
Differential D19832

Add some CMD53-related definitions
ClosedPublic
Actions

Authored by kibab on Apr 5 2019, 4:57 PM.
Tags
None
Referenced Files
F171030418: D19832.id55848.diff
Tue, Sep 8, 7:13 AM
Unknown Object (File)
Fri, Sep 4, 11:57 PM
Unknown Object (File)
Thu, Aug 27, 3:23 PM
Unknown Object (File)
Tue, Aug 25, 2:27 AM
Unknown Object (File)
Tue, Aug 25, 2:27 AM
Unknown Object (File)
Tue, Aug 25, 2:27 AM
Unknown Object (File)
Tue, Aug 25, 2:25 AM
Unknown Object (File)
Wed, Aug 12, 2:16 PM
View All Files
Subscribers
emaste

Details

Reviewers
imp
bz
Commits
rS346100: Add some CMD53-related definitions
Summary

In preparation to adding block mode functions, add necessary definitions.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23624
Build 22609: arc lint + arc unit

Event Timeline

kibab created this revision.Apr 5 2019, 4:57 PM
Harbormaster completed remote builds in B23539: Diff 55848.Apr 5 2019, 4:57 PM
bz accepted this revision.Apr 6 2019, 8:53 PM
This revision is now accepted and ready to land.Apr 6 2019, 8:53 PM
imp added inline comments.Apr 8 2019, 7:59 PM
sys/dev/mmc/mmcreg.h
576

0x00100 is a magic number, Would SD_IO_CCCR_SIZE or some new constant be more appropriate?

kibab updated this revision to Diff 56075.Apr 10 2019, 8:34 PM

Addressed reviewer's comment about magic constant, added more comments.

This revision now requires review to proceed.Apr 10 2019, 8:34 PM
Harbormaster completed remote builds in B23624: Diff 56075.Apr 10 2019, 8:35 PM
kibab marked an inline comment as done.Apr 10 2019, 8:35 PM
imp accepted this revision.Apr 10 2019, 8:42 PM
This revision is now accepted and ready to land.Apr 10 2019, 8:42 PM
Closed by commit rS346100: Add some CMD53-related definitions (authored by kibab). · Explain WhyApr 10 2019, 8:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
mmc/
41 lines

Diff 56075

View Options

sys/dev/mmc/mmcreg.h

Loading...