RISC-V: Initialize pcpu slightly earlier
ClosedPublic
Actions

Authored by mhorne on Mar 27 2019, 3:06 PM.

Details

Reviewers

markj
jhb
br

Commits

rS346021: RISC-V: initialize pcpu slightly earlier

Summary

For some reason, the code emitted for _vprintf will try to load the pcpu
pointer, even though it does nothing with it. In certain cases, printf can be
called before pcpu is initialized, causing a hang in early boot.

Move pcpu initialization up to before any printfs occur.

Test Plan

Noticed this hang when "options TSLOG" was added to my kernel config; test
that the system boots with this option enabled.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Mar 27 2019, 3:06 PM

mhorne added inline comments.

sys/riscv/riscv/machdep.c
124 ↗	(On Diff #55498)	No reason this needs to be a global, as it is not referenced outside of this file.

For some reason, the code emitted for _vprintf will try to load the pcpu pointer, even though it does nothing with it.

This is probably the curthread reference from the TSENTER() macro?

In D19726#422553, @markj wrote:

For some reason, the code emitted for _vprintf will try to load the pcpu pointer, even though it does nothing with it.

This is probably the curthread reference from the TSENTER() macro?

Yep. That would definitely explain it.

Approved. I suggest giving other reviewers a day or so to chime in though.

This revision is now accepted and ready to land.Mar 27 2019, 4:00 PM

Closed by commit rS346021: RISC-V: initialize pcpu slightly earlier (authored by mhorne). · Explain WhyApr 7 2019, 8:12 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2019, 8:12 PM