bectl.8: Clean up & clarify the create subcommand
ClosedPublic
Actions

Authored by 0mp on Mar 20 2019, 11:43 PM.

Details

Reviewers

kevans
bcr

Group Reviewers

manpages

Commits

rS345845: bectl.8: Clean up & clarify the create subcommand

Summary

bectl.8: Clean up & clarify the create subcommand

- Improve formatting
- Use consistent variable names
- Improve the description of the create subcommand (1)

PR:		235850 (1)
Reported by:	ler (1)
Submitted by:	kevans (1)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235850

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

0mp created this revision.Mar 20 2019, 11:43 PM

Herald added a reviewer: manpages. · View Herald TranscriptMar 20 2019, 11:43 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B23222: Diff 55302.Mar 20 2019, 11:43 PM

0mp edited the summary of this revision. (Show Details)Mar 29 2019, 9:08 AM

0mp added reviewers: kevans, bcr.

0mp added a subscriber: ler.

kevans accepted this revision.Apr 3 2019, 1:25 PM

kevans added inline comments.

sbin/bectl/bectl.8
74 ↗	(On Diff #55302)	What is the deal with \&? here?

This revision is now accepted and ready to land.Apr 3 2019, 1:25 PM

0mp added inline comments.Apr 3 2019, 1:43 PM

sbin/bectl/bectl.8
74 ↗	(On Diff #55302)	It is to avoid the following warning: STYLE: no blank before trailing delimiter: Fl h? Basically, we say here that `?` should not be treated differently.

Closed by commit rS345845: bectl.8: Clean up & clarify the create subcommand (authored by 0mp). · Explain WhyApr 3 2019, 1:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

bectl/

bectl.8

139 lines

Diff 55775

View Options

head/sbin/bectl/bectl.8

	Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
	* The number of PHYSSEG entries must be one greater than the number			* The number of PHYSSEG entries must be one greater than the number
	* of phys_avail entries because the phys_avail entry that spans the			* of phys_avail entries because the phys_avail entry that spans the
	* largest physical address that is accessible by ISA DMA is split			* largest physical address that is accessible by ISA DMA is split
	* into two PHYSSEG entries.			* into two PHYSSEG entries.
	*/			*/
	#define VM_PHYSSEG_MAX 63			#define VM_PHYSSEG_MAX 63

	/*			/*
	* Create two free page pools: VM_FREEPOOL_DEFAULT is the default pool			* Create three free page pools: VM_FREEPOOL_DEFAULT is the default pool from
	* from which physical pages are allocated and VM_FREEPOOL_DIRECT is			* which physical pages are allocated and VM_FREEPOOL_DIRECT is the pool from
	* the pool from which physical pages for page tables and small UMA			* which physical pages for page tables and small UMA objects are allocated.
	* objects are allocated.			* VM_FREEPOOL_LAZINIT is a special-purpose pool that is populated only during
				* boot and is used to implement deferred initialization of page structures.
	*/			*/
	#define VM_NFREEPOOL 2			#define VM_NFREEPOOL 3
	#define VM_FREEPOOL_DEFAULT 0			#define VM_FREEPOOL_LAZYINIT 0
	#define VM_FREEPOOL_DIRECT 1			#define VM_FREEPOOL_DEFAULT 1
				#define VM_FREEPOOL_DIRECT 2

	/*			/*
	* Create up to three free page lists: VM_FREELIST_DMA32 is for physical pages			* Create up to three free page lists: VM_FREELIST_DMA32 is for physical pages
	* that have physical addresses below 4G but are not accessible by ISA DMA,			* that have physical addresses below 4G but are not accessible by ISA DMA,
	* and VM_FREELIST_ISADMA is for physical pages that are accessible by ISA			* and VM_FREELIST_ISADMA is for physical pages that are accessible by ISA
	* DMA.			* DMA.
	*/			*/
	#define VM_NFREELIST 3			#define VM_NFREELIST 3
	▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines

bectl.8: Clean up & clarify the create subcommandClosedPublicActions