Page MenuHomeFreeBSD
Differential D2571

Skip adding swap lines to /etc/fstab if swap is 0 sized
ClosedPublic
Actions

Authored by allanjude on May 16 2015, 11:58 PM.
Tags
None
Referenced Files
F105769290: D2571.diff
Fri, Dec 20, 10:48 AM
Unknown Object (File)
Sun, Dec 8, 2:46 AM
Unknown Object (File)
Nov 19 2024, 7:21 PM
Unknown Object (File)
Nov 14 2024, 8:55 AM
Unknown Object (File)
Oct 4 2024, 4:57 PM
Unknown Object (File)
Oct 3 2024, 11:43 PM
Unknown Object (File)
Sep 28 2024, 1:33 AM
Unknown Object (File)
Sep 28 2024, 1:33 AM
View All 54 Files
Subscribers
imp

Details

Reviewers
dteske
dim
eadler
brd
roberto
lattera-gmail.com
Commits
rS283023: bsdinstall/zfsboot: Skip adding swap lines to /etc/fstab if swap is 0 sized
Summary

Reported by: dim

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

allanjude updated this revision to Diff 5434.May 16 2015, 11:58 PM
allanjude retitled this revision from to Skip adding swap lines to /etc/fstab if swap is 0 sized.
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
allanjude added reviewers: dteske, roberto, brd, eadler, dim, lattera-gmail.com.
Herald added a subscriber: imp. · View Herald TranscriptMay 16 2015, 11:58 PM
dim edited edge metadata.May 17 2015, 12:02 AM

LGTM. But this is better reviewed by somebody who knows their way around bsdinstall. :)

eadler accepted this revision.May 17 2015, 12:52 AM
eadler edited edge metadata.

this counts as mentor and src approval. Go ahead

This revision is now accepted and ready to land.May 17 2015, 12:52 AM
Closed by commit rS283023: bsdinstall/zfsboot: Skip adding swap lines to /etc/fstab if swap is 0 sized (authored by allanjude). · Explain WhyMay 17 2015, 12:55 AM
This revision was automatically updated to reflect the committed changes.
allanjude reopened this revision.May 22 2015, 2:25 PM
This revision is now accepted and ready to land.May 22 2015, 2:25 PM
allanjude updated this revision to Diff 5558.May 22 2015, 2:27 PM
allanjude edited edge metadata.

Fix syntax error found by Michael Dexter and Devin Teske

This revision now requires review to proceed.May 22 2015, 2:27 PM
dteske accepted this revision.May 22 2015, 3:33 PM
dteske edited edge metadata.

Let "sh -n filename" be your friend, my friend ;D

In this case, the output of "sh -n zfsboot" was spot-on:
zfsboot: 979: Syntax error: "else" unexpected (expecting "then")

The proposed revision fixes the problem and I approve of this revision (adding "; then"). Thanks Allan.

This revision is now accepted and ready to land.May 22 2015, 3:33 PM
allanjude closed this revision.Jun 15 2015, 8:10 PM

Committed as rS283288

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
2 lines

Diff 5558

View Options

usr.sbin/bsdinstall/scripts/zfsboot

Loading...