Remove eprintf - it was needed only for ancient GCC assert.h
ClosedPublic
Actions

Authored by emaste on May 20 2015, 2:26 AM.

Details

Reviewers

dim
imp

Commits

rG96ab5023fd4b: compiler-rt: remove eprintf

Summary

As far as I can tell:

Prior to 2001 GCC used to provide its own assert.h
The GCC assert.h required __eprintf to emit the error message
FreeBSD's own assert.h never used this

so objects with references to __eprintf must have been compiled with a 15 year old GCC other than the one in the base system. I'm not sure we need to worry about that.

This came up because __eprintf references __stderrp, compilerrt_mumble, fflush and fprintf. This doesn't matter much when used as libgcc.a, although introduces a small additional link-time overhead for probably no value.

I would like to extend compiler-rt to libgcc_s.so as well, and this dependency seems silly there (even if in practice it will not be a problem).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 5505.May 20 2015, 2:26 AM

emaste retitled this revision from to Remove eprintf - it was needed only for ancient GCC assert.h.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: ed.

emaste set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMay 20 2015, 2:26 AM

emaste updated this object.May 20 2015, 2:27 AM

ed accepted this revision.May 20 2015, 7:08 AM

ed edited edge metadata.

This revision is now accepted and ready to land.May 20 2015, 7:08 AM

ed resigned from this revision.Aug 2 2015, 9:58 AM

ed removed a reviewer: ed.

This revision now requires review to proceed.Aug 2 2015, 9:58 AM

From contrib/llvm-project/compiler-rt/lib/builtins/eprintf.c:

// __eprintf() was used in an old version of <assert.h>.
// It can eventually go away, but it is needed when linking
// .o files built with the old <assert.h>.
//
// It should never be exported from a dylib, so it is marked
// visibility hidden.

refresh

Harbormaster completed remote builds in B50360: Diff 118810.Mar 14 2023, 5:03 PM

Yea, we don't necessarily promise compatibility for this, but we could add it to a compatX if there's demand
[edited]

This revision is now accepted and ready to land.Mar 14 2023, 5:10 PM

The comment in the compiler-rt implementation indicates it was only used for static linking, so this would only come up if you tried to build something on modern FreeBSD with a 20-year-old GCC.