`make buildworld' should display the build time in seconds
ClosedPublic
Actions

Authored by wosch on Jan 14 2018, 8:09 PM.

Details

Reviewers

cem
bdrewery

Commits

Summary

the top level `make buildworld' target should display the build time in seconds

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

This looks good in principle, modulo some nits. I'd let Bryan have the final say, but commit it if he says nothing.

Makefile.inc1
968	A fixed name is bad. It's also bad that it's in the makeworld tree. Consider something in /tmp/
973	You never remove this file. You should.
981	I'd use "built" rather than "build" because it describes something that went on in the past (even though it just finished).

You can also just record the time the build starts with something like this:

.if !defined(_BUILDWORLD_START)
_BUILDWORLD_START!= date +%s
.export _BUILDWORLD_START
.endif

Then compare its value in buildworld_epilogue, no tmpfile needed.

The updated patch works without a temp file.

cem accepted this revision.Mar 11 2019, 5:54 PM

This revision is now accepted and ready to land.Mar 11 2019, 5:54 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

9 lines