Page MenuHomeFreeBSD
Differential D13865

Improve comment in socketvar.h
ClosedPublic
Actions

Authored by bz on Jan 11 2018, 5:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 3:53 PM
Unknown Object (File)
Sat, Sep 5, 9:11 PM
Unknown Object (File)
Sat, Sep 5, 6:52 PM
Unknown Object (File)
Sat, Sep 5, 1:29 AM
Unknown Object (File)
Fri, Sep 4, 10:54 PM
Unknown Object (File)
Fri, Sep 4, 1:45 PM
Unknown Object (File)
Fri, Sep 4, 2:10 AM
Unknown Object (File)
Thu, Sep 3, 6:52 PM
View All Files
Subscribers
imp
jhb

Details

Reviewers
gnn
Commits
rS344956: Try to improve comment for socket state bits.
Summary

Try to rewrite (and then reformat as a consequence) the comment.

Test Plan

Have native English speakers read this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Jan 11 2018, 5:00 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 11 2018, 5:00 PM
jhb added a subscriber: jhb.Oct 8 2018, 7:27 PM
jhb added inline comments.
sys/sys/socketvar.h
182 ↗(On Diff #37813)

The "locked differently" reads a bit odd. Maybe something like:

"They are now split into separate, lock-specific fields."

This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2019, 1:37 AM
Closed by commit rS344956: Try to improve comment for socket state bits. (authored by bz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
sys/
14 lines

Diff 54865

View Options

head/sys/sys/socketvar.h

Loading...