Page MenuHomeFreeBSD
Differential D13865

Improve comment in socketvar.h
ClosedPublic
Actions

Authored by bz on Jan 11 2018, 5:00 PM.
Tags
None
Referenced Files
F83037323: D13865.diff
Sun, May 5, 9:03 AM
Unknown Object (File)
Sun, Apr 28, 5:33 AM
Unknown Object (File)
Dec 20 2023, 6:04 AM
Unknown Object (File)
Dec 4 2023, 7:55 AM
Unknown Object (File)
Nov 24 2023, 4:00 AM
Unknown Object (File)
Nov 10 2023, 11:27 AM
Unknown Object (File)
Nov 9 2023, 11:05 AM
Unknown Object (File)
Oct 9 2023, 10:19 AM
View All 17 Files
Subscribers
imp
jhb

Details

Reviewers
gnn
Commits
rS344956: Try to improve comment for socket state bits.
Summary

Try to rewrite (and then reformat as a consequence) the comment.

Test Plan

Have native English speakers read this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 14304

Event Timeline

bz created this revision.Jan 11 2018, 5:00 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 11 2018, 5:00 PM
jhb added a subscriber: jhb.Oct 8 2018, 7:27 PM
jhb added inline comments.
sys/sys/socketvar.h
182

The "locked differently" reads a bit odd. Maybe something like:

"They are now split into separate, lock-specific fields."

This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2019, 1:37 AM
Closed by commit rS344956: Try to improve comment for socket state bits. (authored by bz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
sys/
14 lines

Diff 37813

View Options

sys/sys/socketvar.h

Loading...