Paths

Table of Contentst

Differential D19371

26 head
ClosedPublic
Actions

Authored by kbowling on Feb 26 2019, 10:40 PM.

Tags

None

Referenced Files

	F153773668: D19371.diff
	Thu, Apr 23, 3:03 PM

	Unknown Object (File)
	Tue, Apr 21, 12:39 PM

	Unknown Object (File)
	Sun, Apr 19, 3:47 PM

	Unknown Object (File)
	Sun, Apr 19, 11:48 AM

	Unknown Object (File)
	Sat, Apr 18, 9:37 PM

	Unknown Object (File)
	Fri, Apr 17, 11:53 AM

	Unknown Object (File)
	Wed, Apr 15, 3:44 AM

	Unknown Object (File)
	Sat, Apr 11, 10:41 AM

View All Files

Subscribers

mat

Details

Reviewers

krion
timur
tuexen

Commits

rP494036: net/packetdrill: update to 2019/02/26 head

Summary

Update to latest head

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Feb 26 2019, 10:40 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 26 2019, 10:40 PM

Looks like you left old PORTVERSION

net/packetdrill/Makefile
4	Looks like you left old PORTVERSION

This revision now requires changes to proceed.Feb 26 2019, 10:51 PM

tuexen added inline comments.Feb 27 2019, 7:42 AM

net/packetdrill/Makefile
12	Does it make sense to add `python` here? It is not required for building `packetdrill`, but you can use `python`-code in the scripts and then a working `python` is required to execute such scripts.

Make python a runtime dep and fix portversion derp

Looks good to me.

krion accepted this revision.Feb 27 2019, 9:22 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2019, 9:25 AM

Closed by commit rP494036: net/packetdrill: update to 2019/02/26 head (authored by kbowling). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

net/

packetdrill/

Makefile

6 lines

distinfo

6 lines

Diff 54455

View Options

net/packetdrill/Makefile