Differential D19208

powerpc/mpc85xx: Synchronize timebase the platform correct way
ClosedPublic
Actions

Authored by jhibbits on Feb 16 2019, 4:55 AM.

Details

Reviewers

Commits

rS344613: powerpc/mpc85xx: Synchronize timebase the platform correct way

Summary

To safely synchronize timebase we need to disable the timebase on all
cores, set timebase, and resynchronize. This adds two new devices, mutually
exclusive, which attach on the SoC simplebus, to freeze and unfreeze the
timebase. The devices are singletons, and platform-specific, so I saw no reason
to make them optional and in separate files.

This was found to be necessary for top(1) to work correctly on an AmigaOne
X5000 (P5020 SoC).

Test Plan

Regression test on various Book-E hardware.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22751
Build 21843: arc lint + arc unit

Event Timeline

jhibbits created this revision.Feb 16 2019, 4:55 AM

Herald added subscribers: bdragon, imp. · View Herald TranscriptFeb 16 2019, 4:55 AM

Harbormaster completed remote builds in B22524: Diff 53984.Feb 16 2019, 4:55 AM

Should we panic if freeze_timebase somehow doesn't get set? Or, alternately, fall back on the old lame thing?

I have two alternative paths to go: if (freeze... != NULL), or have a default empty freeze function. Doesn't matter to me which way we go with, but, yes, we need a fallback to do it the lame way.

Add a dummy freezer, to keep the code path easier to follow.

Harbormaster completed remote builds in B22751: Diff 54424.Feb 26 2019, 5:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2019, 3:31 AM

Closed by commit rS344613: powerpc/mpc85xx: Synchronize timebase the platform correct way (authored by jhibbits). · Explain Why

This revision was automatically updated to reflect the committed changes.