Page MenuHomeFreeBSD
Differential D19246

svn: support building as PIE
ClosedPublic
Actions

Authored by emaste on Feb 19 2019, 3:21 PM.
Tags
None
Referenced Files
F157098808: D19246.id54069.diff
Mon, May 18, 10:46 AM
F157076005: D19246.id.diff
Mon, May 18, 7:23 AM
F157062593: D19246.id.diff
Mon, May 18, 5:29 AM
F157045762: D19246.id54183.diff
Mon, May 18, 3:00 AM
Unknown Object (File)
Fri, May 15, 10:23 AM
Unknown Object (File)
Sun, May 10, 1:58 AM
Unknown Object (File)
Sat, May 2, 10:02 PM
Unknown Object (File)
Wed, Apr 29, 5:20 AM
View All Files
Subscribers
cem
imp

Details

Reviewers
peter
cem
Commits
rS362180: Update Subversion and dependencies to 1.14.0 LTS.
rS344438: svn: support building with WITH_PIE

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Feb 19 2019, 3:21 PM
cem accepted this revision.Feb 19 2019, 5:56 PM

Why is the MK_PIE PIE_SUFFIX “_pic”? That seems inconsistent. Otherwise, LGTM.

(Seems like we could just dump all of these “.a” into a single library as well to simplify the build, but that is an orthogonal improvement.)

This revision is now accepted and ready to land.Feb 19 2019, 5:56 PM
emaste added a comment.Feb 19 2019, 6:02 PM
In D19246#411794, @cem wrote:

Why is the MK_PIE PIE_SUFFIX “_pic”? That seems inconsistent. Otherwise, LGTM.

Leftover from an earlier iteration of D18423

usr.bin/svn/Makefile.inc
44 ↗(On Diff #54069)

Will s/_pic/_pie/ here

emaste added inline comments.Feb 19 2019, 10:27 PM
usr.bin/svn/Makefile.inc
5 ↗(On Diff #54069)

Oh, need to remove this as well :)

Closed by commit rS344438: svn: support building with WITH_PIE (authored by emaste). · Explain WhyFeb 21 2019, 3:08 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 21 2019, 3:08 PM
dim added a commit: rS362180: Update Subversion and dependencies to 1.14.0 LTS..Jun 18 2020, 9:19 AM

Revision Contents
Changeset List

PathSize
head/
usr.bin/
svn/
39 lines
svn/
34 lines
svnadmin/
18 lines
svnbench/
34 lines
svndumpfilter/
18 lines
svnfsfs/
18 lines
svnlook/
20 lines
svnmucc/
34 lines
svnrdump/
34 lines
svnserve/
28 lines
svnsync/
28 lines
svnversion/
12 lines

Diff 54183

View Options

head/usr.bin/svn/Makefile.inc

Loading...
View Options

head/usr.bin/svn/svn/Makefile

Loading...
View Options

head/usr.bin/svn/svnadmin/Makefile

Loading...
View Options

head/usr.bin/svn/svnbench/Makefile

Loading...
View Options

head/usr.bin/svn/svndumpfilter/Makefile

Loading...
View Options

head/usr.bin/svn/svnfsfs/Makefile

Loading...
View Options

head/usr.bin/svn/svnlook/Makefile

Loading...
View Options

head/usr.bin/svn/svnmucc/Makefile

Loading...
View Options

head/usr.bin/svn/svnrdump/Makefile

Loading...
View Options

head/usr.bin/svn/svnserve/Makefile

Loading...
View Options

head/usr.bin/svn/svnsync/Makefile

Loading...
View Options

head/usr.bin/svn/svnversion/Makefile

Loading...