Page MenuHomeFreeBSD

svn: support building as PIE
ClosedPublic

Authored by emaste on Feb 19 2019, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 31 2022, 4:35 PM
Unknown Object (File)
Dec 20 2022, 7:38 AM
Unknown Object (File)
Nov 29 2022, 4:21 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Why is the MK_PIE PIE_SUFFIX “_pic”? That seems inconsistent. Otherwise, LGTM.

(Seems like we could just dump all of these “.a” into a single library as well to simplify the build, but that is an orthogonal improvement.)

This revision is now accepted and ready to land.Feb 19 2019, 5:56 PM
In D19246#411794, @cem wrote:

Why is the MK_PIE PIE_SUFFIX “_pic”? That seems inconsistent. Otherwise, LGTM.

Leftover from an earlier iteration of D18423

usr.bin/svn/Makefile.inc
44 ↗(On Diff #54069)

Will s/_pic/_pie/ here

usr.bin/svn/Makefile.inc
5 ↗(On Diff #54069)

Oh, need to remove this as well :)

This revision was automatically updated to reflect the committed changes.