Page MenuHomeFreeBSD
Differential D19221

Use iconv to ensure the output of calendar respects the output encoding
ClosedPublic
Actions

Authored by bapt on Feb 17 2019, 10:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 3:30 PM
Unknown Object (File)
Nov 24 2024, 1:41 PM
Unknown Object (File)
Nov 21 2024, 3:04 PM
Unknown Object (File)
Nov 21 2024, 1:59 PM
Unknown Object (File)
Nov 20 2024, 5:46 AM
Unknown Object (File)
Nov 20 2024, 5:41 AM
Unknown Object (File)
Nov 18 2024, 4:26 PM
Unknown Object (File)
Nov 14 2024, 6:39 PM
View All 73 Files
Subscribers
imp
jilles

Details

Reviewers
yuripv
jilles
Commits
rS345577: MFC r344340:
rS344340: calendar: use iconv to respect the output encoding
Summary

Use iconv to ensure the output of calendar respects the output encoding

Test Plan

tested with french and russian calendars

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22539
Build 21680: arc lint + arc unit

Event Timeline

bapt created this revision.Feb 17 2019, 10:56 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2019, 10:56 AM
Harbormaster completed remote builds in B22538: Diff 54008.Feb 17 2019, 10:56 AM
bapt added a reviewer: yuripv.Feb 17 2019, 11:01 AM
jilles added a subscriber: jilles.Feb 17 2019, 1:03 PM
jilles added inline comments.
usr.bin/calendar/calendar.c
91–96

Perhaps nl_langinfo(CODESET) is better than hard-coding the locale name format.

usr.bin/calendar/events.c
83

Style: the open brace should be on a line by itself.

193

This strdup is unnecessary. The pointer can be saved instead and freed after the asprintf.

bapt updated this revision to Diff 54011.Feb 17 2019, 3:41 PM

Address @jilles comments

Harbormaster completed remote builds in B22539: Diff 54011.Feb 17 2019, 3:41 PM
bapt added a reviewer: jilles.Feb 17 2019, 3:42 PM
bapt updated this revision to Diff 54012.Feb 17 2019, 3:43 PM
bapt marked an inline comment as done.

Fix style

Harbormaster completed remote builds in B22540: Diff 54012.Feb 17 2019, 3:43 PM
bapt marked 2 inline comments as done.Feb 17 2019, 3:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2019, 6:41 AM
Closed by commit rS344340: calendar: use iconv to respect the output encoding (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
calendar/
4 lines
7 lines
10 lines
137 lines
3 lines

Diff 54011

View Options

usr.bin/calendar/Makefile

Loading...
View Options

usr.bin/calendar/calendar.h

Loading...
View Options

usr.bin/calendar/calendar.c

Loading...
View Options

usr.bin/calendar/events.c

Loading...
View Options

usr.bin/calendar/io.c

Loading...