Page MenuHomeFreeBSD

Use iconv to ensure the output of calendar respects the output encoding
ClosedPublic

Authored by bapt on Feb 17 2019, 10:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 9:07 AM
Unknown Object (File)
Feb 18 2024, 2:06 PM
Unknown Object (File)
Feb 1 2024, 10:21 PM
Unknown Object (File)
Feb 1 2024, 10:21 PM
Unknown Object (File)
Jan 19 2024, 7:34 AM
Unknown Object (File)
Dec 20 2023, 10:05 PM
Unknown Object (File)
Dec 20 2023, 3:49 AM
Unknown Object (File)
Nov 9 2023, 9:32 AM
Subscribers

Details

Summary

Use iconv to ensure the output of calendar respects the output encoding

Test Plan

tested with french and russian calendars

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jilles added inline comments.
usr.bin/calendar/calendar.c
90–95 ↗(On Diff #54008)

Perhaps nl_langinfo(CODESET) is better than hard-coding the locale name format.

usr.bin/calendar/events.c
83 ↗(On Diff #54008)

Style: the open brace should be on a line by itself.

198 ↗(On Diff #54008)

This strdup is unnecessary. The pointer can be saved instead and freed after the asprintf.

bapt marked an inline comment as done.

Fix style

bapt marked 2 inline comments as done.Feb 17 2019, 3:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2019, 6:41 AM
This revision was automatically updated to reflect the committed changes.