Paths

Table of Contentst

Differential D19221

Use iconv to ensure the output of calendar respects the output encoding
ClosedPublic
Actions

Authored by bapt on Feb 17 2019, 10:56 AM.

Tags

None

Referenced Files

	F153490257: D19221.diff
	Tue, Apr 21, 11:02 AM

	F153413824: D19221.diff
	Tue, Apr 21, 12:55 AM

	Unknown Object (File)
	Mon, Apr 20, 8:59 AM

	Unknown Object (File)
	Sun, Apr 19, 8:54 PM

	Unknown Object (File)
	Sat, Apr 18, 1:59 PM

	Unknown Object (File)
	Wed, Apr 15, 9:07 PM

	Unknown Object (File)
	Fri, Apr 10, 8:02 PM

	Unknown Object (File)
	Thu, Apr 9, 6:00 PM

Subscribers

Details

Reviewers

yuripv
jilles

Commits

rS345577: MFC r344340:
rS344340: calendar: use iconv to respect the output encoding

Summary

Use iconv to ensure the output of calendar respects the output encoding

Test Plan

tested with french and russian calendars

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22538
Build 21679: arc lint + arc unit

Event Timeline

bapt created this revision.Feb 17 2019, 10:56 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2019, 10:56 AM

Harbormaster completed remote builds in B22538: Diff 54008.Feb 17 2019, 10:56 AM

bapt added a reviewer: yuripv.Feb 17 2019, 11:01 AM

jilles added a subscriber: jilles.Feb 17 2019, 1:03 PM

jilles added inline comments.

usr.bin/calendar/calendar.c
90–95	Perhaps `nl_langinfo(CODESET)` is better than hard-coding the locale name format.
usr.bin/calendar/events.c
83	Style: the open brace should be on a line by itself.
198	This strdup is unnecessary. The pointer can be saved instead and freed after the asprintf.

Address @jilles comments

Harbormaster completed remote builds in B22539: Diff 54011.Feb 17 2019, 3:41 PM

bapt added a reviewer: jilles.Feb 17 2019, 3:42 PM

Fix style

Harbormaster completed remote builds in B22540: Diff 54012.Feb 17 2019, 3:43 PM

bapt marked 2 inline comments as done.Feb 17 2019, 3:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2019, 6:41 AM

Closed by commit rS344340: calendar: use iconv to respect the output encoding (authored by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

calendar/

4 lines

7 lines

18 lines

141 lines

3 lines

Diff 54008

usr.bin/calendar/Makefile

Loading...

usr.bin/calendar/calendar.h

Loading...

usr.bin/calendar/calendar.c

Loading...

usr.bin/calendar/events.c

Loading...

usr.bin/calendar/io.c

Loading...