Bug 232918 reported a missing nslookup dependency. Added and incremented PORTREVISION by 1
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 22360 Build 21535: arc lint + arc unit
Event Timeline
Comment Actions
Overall, LGTM. See also bug 235351 and add ftp/curl.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235351
| sysutils/getssl/distinfo | ||
|---|---|---|
| 1 | You need not to update TIMESTAMP if there's no change on the distfile. | |
| sysutils/getssl/Makefile | ||
|---|---|---|
| 15 | curl:ftp/curl Otherwise, LGTM. | |
Comment Actions
depending on dns/bind-tools is probably a bad idea, the port will
| sysutils/getssl/Makefile | ||
|---|---|---|
| 15 | Please try to put only one dependency per line. | |
Comment Actions
Even if it is a bad idea, this port actually and already depends on dns/bind-tools (nslookup) just not declared in ports Makefile.
This diff just tries to declare dependencies correctly. Does ports tree have drop-in replacement of bind-tools?
| sysutils/getssl/Makefile | ||
|---|---|---|
| 15 | My bad, mistyped! Thanks for catching that :) | |
| 15 | @mat I'd be happy to format this appropriately if you can point me to the right documentation. I didn't see anything in the porter's handbook, but it's been a while since I had cause to poke at my ports (no reviewer or mentor anymore) and I've been insanely busy, which means I could simply be forgetting. | |
| sysutils/getssl/distinfo | ||
| 1 | I'll remember that for the future. Thanks! | |
Comment Actions
@mat doesn't reply dns/bind-tools WILL WHAT but LGTM.
depending on dns/bind-tools is probably a bad idea, the port will
| sysutils/getssl/Makefile | ||
|---|---|---|
| 15 | Use tab after RUN_DEPENDS=. That's OK right now. I'll fix it. | |