Page MenuHomeFreeBSD

Update: sysutils/getssl to 2.10_p1

Authored by on Nov 11 2018, 10:25 PM.



Bug 232918 reported a missing nslookup dependency. Added and incremented PORTREVISION by 1

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

meta added a subscriber: meta.Feb 5 2019, 2:07 AM

Overall, LGTM. See also bug 235351 and add ftp/curl.

1 ↗(On Diff #50294)

You need not to update TIMESTAMP if there's no change on the distfile.

Update to include ftp/curl

meta added inline comments.Feb 6 2019, 2:50 AM
15 ↗(On Diff #53614)


Otherwise, LGTM.

meta added a reviewer: meta.Feb 6 2019, 2:52 AM
mat added a comment.Feb 6 2019, 8:49 AM

depending on dns/bind-tools is probably a bad idea, the port will

15 ↗(On Diff #53614)

Please try to put only one dependency per line.

meta added a comment.Feb 7 2019, 2:22 AM
In D17954#408241, @mat wrote:

depending on dns/bind-tools is probably a bad idea, the port will

will what?

meta added a comment.Feb 7 2019, 2:35 AM

Even if it is a bad idea, this port actually and already depends on dns/bind-tools (nslookup) just not declared in ports Makefile.
This diff just tries to declare dependencies correctly. Does ports tree have drop-in replacement of bind-tools?

Fix missing curl binary from ftp/curl package dependency marked 2 inline comments as done.Feb 9 2019, 3:38 AM added inline comments.
15 ↗(On Diff #53614)

My bad, mistyped! Thanks for catching that :)

15 ↗(On Diff #53614)

@mat I'd be happy to format this appropriately if you can point me to the right documentation. I didn't see anything in the porter's handbook, but it's been a while since I had cause to poke at my ports (no reviewer or mentor anymore) and I've been insanely busy, which means I could simply be forgetting.

1 ↗(On Diff #50294)

I'll remember that for the future. Thanks!

meta accepted this revision.Feb 11 2019, 2:06 PM

@mat doesn't reply dns/bind-tools WILL WHAT but LGTM.

depending on dns/bind-tools is probably a bad idea, the port will

This revision is now accepted and ready to land.Feb 11 2019, 2:06 PM
meta added inline comments.Feb 11 2019, 2:10 PM
15 ↗(On Diff #53614)

Use tab after RUN_DEPENDS=. That's OK right now. I'll fix it.

This revision was automatically updated to reflect the committed changes.