Implement early_putc for ARM PL011 uart. This will be useful for debugging
failures during early boot.
[RFC, I can commit it if it will be useful.]
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 22341
Event Timeline
| sys/dev/uart/uart_dev_pl011.c | ||
|---|---|---|
| 615 | Unfortunately we can't just have this, it needs to be (for anything that might be in GENERIC on arm or arm64): #if 0 #ifdef EARLY_PRINTF ... #endif #endif | |
Comment Actions
On second thought, for now I think I will drop this until we have a better EARLY_PRINTF
| sys/dev/uart/uart_dev_pl011.c | ||
|---|---|---|
| 615 | Yes, it was a bad idea. Additionally, on arm64 we seem to do a 1G mapping for the address space. I will drop the patches until both of the problems are fixed. | |
| sys/dev/uart/uart_dev_pl011.c | ||
|---|---|---|
| 615 | It is seriously not worth complicating the EARLY_PRINTF code with any kind of scheme for avoiding symbol clashes. By design, this code is turned off all the time, and it should be. The need for it is so rare, and the implementations of it are so machine/board/chip-specific, that by design you build a custom kernel with the right things enabled to use it for the target you're working on just when you need it. | |
| sys/dev/uart/uart_dev_pl011.c | ||
|---|---|---|
| 615 | Probably calling it "problems" was not accurate. EARLY_PRINTF was really useful to figure out a memory region setup failure I saw. Having to edit source files to enable a conf option somehow seems strange to me, that is why I was not keen on checking it in. | |