Most file systems and disk labeling schemes allow dashes as a valid character
in their names. Examples are MSDOS, GPT, and ext*
However, current implementation of UFS does not allow dashes.
Details
Details
- Reviewers
mckusick 0mp imp - Group Reviewers
manpages - Commits
- rS343548: Allow dashes as a valid character in UFS labels.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 22197 Build 21407: arc lint + arc unit
Event Timeline
Comment Actions
OK form manpages, Make sure to bump the date in the manual pages when you commit.
| sbin/tunefs/tunefs.c | ||
|---|---|---|
| 193 | style(9)? It should be indented with 4 spaces instead, right? | |
Comment Actions
As noted, date at top of manual pages needs to be updated (which I will admit, I failed to do when I added underscores).
| sbin/newfs/newfs.8 | ||
|---|---|---|
| 92 | Plural is correct. `Legal characters are' describes all the legal things that can appear in a label of which there may be multiple alphanumerics, multiple dashes, and multiple underscores. | |
| sbin/tunefs/tunefs.8 | ||
| 115 | My same comment as above: leave plurals, add comma. | |
| sbin/tunefs/tunefs.c | ||
| 193 | Agreed, should be four spaces. | |
Comment Actions
Dashes in labels won't cause problems for geom or the boot loader, so I think this is a good change. Thanks for driving it.