Page MenuHomeFreeBSD

Create crtsavres.o for powerpc builds
ClosedPublic

Authored by jhibbits on Jan 11 2019, 9:59 PM.
Tags
None
Referenced Files
F131435788: D18826.id52799.diff
Wed, Oct 8, 1:12 AM
F131435734: D18826.id52801.diff
Wed, Oct 8, 1:11 AM
F131435730: D18826.id52798.diff
Wed, Oct 8, 1:11 AM
F131435191: D18826.id52785.diff
Wed, Oct 8, 1:02 AM
F131429626: D18826.diff
Tue, Oct 7, 11:41 PM
Unknown Object (File)
Wed, Oct 1, 9:11 AM
Unknown Object (File)
Thu, Sep 25, 2:43 AM
Unknown Object (File)
Thu, Sep 18, 1:42 PM
Subscribers

Details

Summary

GCC expects to link in a crtsavres.o on powerpc platforms. On
powerpc64 this is an empty file, but on powerpc and powerpcspe this does contain
some save/restore functions, which may not actually be necessary for newer
modern GCC and clang. This appeases the in-tree gcc, though.

Test Plan

buildworld

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You should remove crtsavres.o from gnu/lib/csu/Makefile

lib/csu/powerpc/crtsavres.S
9–11 ↗(On Diff #52785)

We've been moving to the BSD 1 clause license for crt code as it tends to end up in all binaries. See lib/csu/common/crtbegin.c for an example.

jhibbits added inline comments.
lib/csu/powerpc/crtsavres.S
9–11 ↗(On Diff #52785)

Woops, sorry. Copied the wrong license header. Fixed now.

jhibbits marked an inline comment as done.

Remove crtsavres.o from gnu/lib/csu.

andrew added inline comments.
lib/csu/powerpc64/Makefile
5 ↗(On Diff #52799)

There's an extra space at the end of the line.

This revision is now accepted and ready to land.Jan 12 2019, 8:44 PM
This revision was automatically updated to reflect the committed changes.