Page MenuHomeFreeBSD

Create crtsavres.o for powerpc builds
ClosedPublic

Authored by jhibbits on Jan 11 2019, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 2:10 PM
Unknown Object (File)
Fri, Apr 19, 1:12 PM
Unknown Object (File)
Thu, Apr 11, 5:36 PM
Unknown Object (File)
Mar 11 2024, 3:58 PM
Unknown Object (File)
Mar 11 2024, 3:58 PM
Unknown Object (File)
Mar 11 2024, 3:58 PM
Unknown Object (File)
Mar 11 2024, 3:54 PM
Unknown Object (File)
Mar 11 2024, 3:54 PM
Subscribers

Details

Summary

GCC expects to link in a crtsavres.o on powerpc platforms. On
powerpc64 this is an empty file, but on powerpc and powerpcspe this does contain
some save/restore functions, which may not actually be necessary for newer
modern GCC and clang. This appeases the in-tree gcc, though.

Test Plan

buildworld

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21940
Build 21183: arc lint + arc unit

Event Timeline

You should remove crtsavres.o from gnu/lib/csu/Makefile

lib/csu/powerpc/crtsavres.S
10–12

We've been moving to the BSD 1 clause license for crt code as it tends to end up in all binaries. See lib/csu/common/crtbegin.c for an example.

jhibbits added inline comments.
lib/csu/powerpc/crtsavres.S
10–12

Woops, sorry. Copied the wrong license header. Fixed now.

jhibbits marked an inline comment as done.

Remove crtsavres.o from gnu/lib/csu.

andrew added inline comments.
lib/csu/powerpc64/Makefile
5

There's an extra space at the end of the line.

This revision is now accepted and ready to land.Jan 12 2019, 8:44 PM
This revision was automatically updated to reflect the committed changes.