Differential D17803

Clamp porthash_max to IPPORT_MAX.
ClosedPublic
Actions

Authored by markj on Nov 1 2018, 3:31 PM.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rS341595: Clamp the INPCB port hash tables to IPPORT_MAX + 1 chains.

Summary

The port hash function is just (lport & mask), so it makes no sense to
permit more than IPPORT_MAX hash table entries. On larger-memory
systems this just ends up wasting memory.

Also change the lbgroup hash table size to porthash_max, since it uses
the lport as a hash.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21358
Build 20685: arc lint + arc unit

Event Timeline

markj created this revision.Nov 1 2018, 3:31 PM

Harbormaster completed remote builds in B20575: Diff 49885.Nov 1 2018, 3:31 PM

markj added a reviewer: network.Nov 1 2018, 3:33 PM

Fix an off-by-one.
Retire INP_PCBLBGROUP_PORTHASH. It's identical to INP_PCBPORTHASH, and because we now size the hash tables accurately, it would be nice to consistently use the same port hash everywhere.

Herald added a subscriber: ae. · View Herald TranscriptDec 4 2018, 4:34 PM

Harbormaster completed remote builds in B21358: Diff 51583.Dec 4 2018, 4:34 PM

glebius accepted this revision.Dec 4 2018, 10:08 PM

This revision is now accepted and ready to land.Dec 4 2018, 10:08 PM

Closed by commit rS341595: Clamp the INPCB port hash tables to IPPORT_MAX + 1 chains. (authored by markj). · Explain WhyDec 5 2018, 5:09 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 5 2018, 5:09 PM