Differential D17532

Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case
ClosedPublic
Actions

Authored by ae on Oct 12 2018, 12:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 2, 9:57 PM

	Unknown Object (File)
	Mar 2 2024, 5:10 PM

	Unknown Object (File)
	Feb 24 2024, 4:17 PM

	Unknown Object (File)
	Dec 23 2023, 1:56 AM

	Unknown Object (File)
	Dec 21 2023, 1:54 AM

	Unknown Object (File)
	Nov 18 2023, 9:55 AM

	Unknown Object (File)
	Nov 18 2023, 9:27 AM

	Unknown Object (File)
	Nov 18 2023, 4:38 AM

View All 28 Files

Subscribers

Details

Reviewers

Group Reviewers

manpages
network

Commits

rS341471: Reimplement how net.inet.ip.fw.dyn_keep_states works.

Summary

The net.inet.ip.fw.dyn_keep_states sysctl variable allows to keep dynamic states when parent rule is deleted. But it works only when the default rule is "allow from any to any". The proposed patch reworks this. Now when rule with dynamic opcode is going to be deleted, and net.inet.ip.fw.dyn_keep_states is enabled, existing states will reference named objects, corresponding to this rule, and also reference the rule.
So, when ipfw_dyn_lookup_state() will find state for deleted parent rule, it will return the pointer to the deleted rule, that is still valid.
Also now it is possible to delete only specified dynamic states without touching static rules using -D flag with ipfw(8).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ae created this revision.Oct 12 2018, 12:13 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 12 2018, 12:13 PM

Harbormaster completed remote builds in B20158: Diff 49053.Oct 12 2018, 12:13 PM

Correct the size of allocated buffer to keep bitmask

Harbormaster completed remote builds in B20159: Diff 49054.Oct 12 2018, 12:20 PM

added verbose mode for listing dynamic states
added ability to delete only dynamic states

Herald added a reviewer: manpages. · View Herald TranscriptNov 13 2018, 1:04 PM

Harbormaster completed remote builds in B20784: Diff 50362.Nov 13 2018, 1:04 PM

ae edited the summary of this revision. (Show Details)Nov 13 2018, 1:06 PM

ae added a reviewer: network.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 4 2018, 4:03 PM

Closed by commit rS341471: Reimplement how net.inet.ip.fw.dyn_keep_states works. (authored by ae). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netpfil/

ipfw/

ip_fw_dynamic.c

209 lines

ip_fw_eaction.c

117 lines

ip_fw_private.h

33 lines

ip_fw_sockopt.c

201 lines

nat64/

nat64lsn_control.c

1 line

nat64stl_control.c

1 line

nptv6/

1 line

Diff 51582

head/sys/netpfil/ipfw/ip_fw_dynamic.c

Loading...

head/sys/netpfil/ipfw/ip_fw_eaction.c

Loading...

head/sys/netpfil/ipfw/ip_fw_private.h

Loading...

head/sys/netpfil/ipfw/ip_fw_sockopt.c

Loading...

head/sys/netpfil/ipfw/nat64/nat64lsn_control.c

Loading...

head/sys/netpfil/ipfw/nat64/nat64stl_control.c

Loading...

head/sys/netpfil/ipfw/nptv6/nptv6.c

Loading...