csu when MK_BSD_CRTBEGIN is off
ClosedPublic
Actions

Authored by andrew on Dec 4 2018, 10:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 24, 7:50 AM

	Unknown Object (File)
	Thu, Sep 24, 7:50 AM

	Unknown Object (File)
	Wed, Sep 23, 9:34 PM

	Unknown Object (File)
	Tue, Sep 22, 1:40 AM

	Unknown Object (File)
	Thu, Sep 17, 6:06 PM

	Unknown Object (File)
	Fri, Sep 11, 4:11 PM

	Unknown Object (File)
	Sun, Sep 6, 2:16 PM

	Unknown Object (File)
	Sun, Sep 6, 11:09 AM

View All Files

Subscribers

imp

lwhsu

Details

Reviewers

bdrewery
emaste

Commits

rS352400: MFC r341489:
rS341489: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.

Summary

I expect this will fix bug 233733, however have been unable to reproduce.

PR: 233733

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21355
Build 20682: arc lint + arc unit

Event Timeline

andrew created this revision.Dec 4 2018, 10:56 AM

Harbormaster completed remote builds in B21355: Diff 51573.Dec 4 2018, 10:56 AM

Yes we should build only one or the other and _startup_libs reaching into gnu/lib/csu directly bypassed the ${MK_BSD_CRTBEGIN} test in gnu/lib/Makefile.

This revision is now accepted and ready to land.Dec 4 2018, 2:23 PM

Closed by commit rS341489: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off. (authored by andrew). · Explain WhyDec 4 2018, 6:52 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 4 2018, 6:52 PM

andrew added a commit: rS352400: MFC r341489:.Sep 16 2019, 2:42 PM

Revision Contents
Changeset List

Path

Size

Makefile.inc1

6 lines

Diff 51573

View Options

Only gnu/lib/csu when MK_BSD_CRTBEGIN is offClosedPublicActions