x11-fm/nautilus-python: Python nautilus bindings
AbandonedPublic
Actions

Authored by swills on Dec 3 2018, 8:28 AM.

Details

Reviewers

kwm
daniel_shafer.cc

Summary

x11-fm/nautilus-python: Python nautilus bindings

Nautilus-python is a set of python bindings for the Nautilus Extension 
Framework. With these bindings, you can write extensions for the 
Nautilus File Manager in python.

WWW: https://wiki.gnome.org/Projects/NautilusPython

PR: 234548
Submitted by: Daniel Shafer <daniel shafer cc>
Differential_Revision: D18415

This is a recreation of the Nautilus python extension, updated for Nautilus 3.

Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 112amd64, 12amd64, GTKDOC option tested)
maketest: NA

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 21322
Build 20654: arc lint + arc unit

Event Timeline

daniel_shafer.cc created this revision.Dec 3 2018, 8:28 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 3 2018, 8:28 AM

Harbormaster completed remote builds in B21322: Diff 51518.Dec 3 2018, 8:28 AM

lantw44_gmail.com added a subscriber: lantw44_gmail.com.Dec 3 2018, 11:55 AM

lantw44_gmail.com added inline comments.Dec 3 2018, 12:14 PM

x11-fm/py-nautilus/Makefile
14	Using GPLv2+ will be better because its source file says 'either version 2, or (at your option) any later version.'

Updated LICENSE to GPLv2+

Harbormaster completed remote builds in B21339: Diff 51542.Dec 3 2018, 6:44 PM

koobs added a subscriber: koobs.Dec 4 2018, 3:16 AM

koobs added inline comments.

x11-fm/py-nautilus/Makefile
5	Upstream name is `nautilus-python` (suffixed, not prefixed), can we call it that?
6	Looks like upstream has 1.2.2 [1] [1] https://github.com/GNOME/nautilus-python/tree/NAUTILUS_PYTHON_1_2_2
x11-fm/py-nautilus/pkg-plist
2	Is this shared library stripped by default, or is a post-install: ${STRIP_CMD} needed? Review TEST PLAN section was not populated

mat added inline comments.Dec 6 2018, 4:16 PM

x11-fm/py-nautilus/Makefile
8–9	MASTER_SITES= GNOME/sources/nautilus-python/${PORTVERSION:R}

ndowens_yahoo.com added a subscriber: ndowens_yahoo.com.Dec 8 2018, 3:50 AM

ndowens_yahoo.com added inline comments.

x11-fm/py-nautilus/Makefile
29	Line 28 & 29 should go above OPTIONS section ; as it is out of order per handbook

Rebased the port

After discussing with kwm, it is agreed on that nautilus-python is a good name
as it is a Nautilus Extension, similar to nautilus-sendto. I have also cleaned
up the port and corrected any issues with port ordering, portlint came back
clean. It is not a shared library so there were things I removed to clean
up the port.

Harbormaster completed remote builds in B21691: Diff 52255.Dec 23 2018, 9:00 AM

daniel_shafer.cc retitled this revision from x11-fm/py-nautilus: Updated port for nautilus python bindings to x11-fm/nautilus-python: Recreating port for updated nautilus python bindings extension..Dec 23 2018, 9:01 AM

daniel_shafer.cc edited the summary of this revision. (Show Details)

mat added inline comments.Dec 24 2018, 11:39 AM

x11-fm/nautilus-python/Makefile
27 ↗	(On Diff #52255)	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

Moved INSTALL_TARGET to correct location.

Harbormaster completed remote builds in B21724: Diff 52302.Dec 24 2018, 9:51 PM

daniel_shafer.cc retitled this revision from x11-fm/nautilus-python: Recreating port for updated nautilus python bindings extension. to x11-fm/nautilus-python: Python nautilus bindings.Jan 1 2019, 9:08 PM

daniel_shafer.cc edited the summary of this revision. (Show Details)

daniel_shafer.cc edited the test plan for this revision. (Show Details)

koobs edited the summary of this revision. (Show Details)Jan 2 2019, 5:27 AM