Remove unnecessary GNUC test
ClosedPublic
Actions

Authored by emaste on May 1 2015, 4:56 PM.

Tags

None

Referenced Files

	F153395802: D2422.id5139.diff
	Mon, Apr 20, 10:10 PM

	F153395495: D2422.id5139.diff
	Mon, Apr 20, 10:07 PM

	Unknown Object (File)
	Mon, Apr 20, 10:25 AM

	Unknown Object (File)
	Sun, Apr 19, 9:32 PM

	Unknown Object (File)
	Sat, Apr 18, 1:23 PM

	Unknown Object (File)
	Mon, Apr 6, 12:18 PM

	Unknown Object (File)
	Tue, Mar 31, 3:18 AM

	Unknown Object (File)
	Mon, Mar 30, 8:25 PM

View All Files

Subscribers

None

Details

Reviewers

kib
imp

Commits

rS282551: Remove historical GNUC test

Summary

The requirement was for a GCC-compatible compiler, not necessarily GCC itself. We expect any compiler used for building all of FreeBSD to be GCC-compatible and many things will break if not; there's no point in having an explicit test for this in rtld.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 5139.May 1 2015, 4:56 PM

emaste retitled this revision from to https://reviews.freebsd.org/D2421.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: kib, imp.

emaste retitled this revision from https://reviews.freebsd.org/D2421 to Remove unnecessary GNUC test.

Yes, I agree that the check lived past its usefulness. It is there from the import of the ElfKit, i.e. it was not intended e.g. to port to icc or some other compiler.

This revision is now accepted and ready to land.May 1 2015, 5:16 PM