Page MenuHomeFreeBSD

Remove unnecessary GNUC test
ClosedPublic

Authored by emaste on May 1 2015, 4:56 PM.
Tags
None
Referenced Files
F105952347: D2422.diff
Mon, Dec 23, 1:10 AM
Unknown Object (File)
Tue, Dec 10, 9:17 AM
Unknown Object (File)
Sun, Nov 24, 9:57 PM
Unknown Object (File)
Nov 23 2024, 1:42 AM
Unknown Object (File)
Nov 22 2024, 5:09 PM
Unknown Object (File)
Nov 21 2024, 12:23 PM
Unknown Object (File)
Nov 19 2024, 11:47 AM
Unknown Object (File)
Nov 11 2024, 12:37 AM
Subscribers
None

Details

Summary

The requirement was for a GCC-compatible compiler, not necessarily GCC itself. We expect any compiler used for building all of FreeBSD to be GCC-compatible and many things will break if not; there's no point in having an explicit test for this in rtld.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to https://reviews.freebsd.org/D2421.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: kib, imp.
emaste retitled this revision from https://reviews.freebsd.org/D2421 to Remove unnecessary GNUC test.
kib edited edge metadata.

Yes, I agree that the check lived past its usefulness. It is there from the import of the ElfKit, i.e. it was not intended e.g. to port to icc or some other compiler.

This revision is now accepted and ready to land.May 1 2015, 5:16 PM
imp edited edge metadata.

I almost deleted these for some stuff I was doing here...

This revision was automatically updated to reflect the committed changes.