Fix -DNO_CLEAN amd64 build after r340463
ClosedPublic
Actions

Authored by arichardson on Nov 18 2018, 10:06 AM.

Details

Reviewers

mjg
emaste
bdrewery

Commits

rS340587: Fix -DNO_CLEAN amd64 build after r340463

Summary

Without this change I got the following error:
clang-7: error: no such file or directory: '/Users/alex/cheri/freebsd-master/lib/libc/amd64/string/bzero.S'

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20874
Build 20250: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 18 2018, 10:06 AM

Harbormaster completed remote builds in B20874: Diff 50554.Nov 18 2018, 10:06 AM

Are you sure that on your box a *failing* -DNO_CLEAN starts building again with this change? Are you using meta-mode? I had a similar change locally and the build kept failing anyway, no meta-mode though.

It worked afterward I made this change but I'm not 100% certain that it was because of this patch (not using META_MODE).

So I retested with your change. a failing build indeed is fixed. Perhaps my original change had a typo or compatible. Thanks.

This revision is now accepted and ready to land.Nov 18 2018, 2:21 PM

Closed by commit rS340587: Fix -DNO_CLEAN amd64 build after r340463 (authored by arichardson). · Explain WhyNov 18 2018, 7:55 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 18 2018, 7:55 PM