Differential D2381

vm_fault: Fix deadlock between vm_map_wire and vm_fault_hold
ClosedPublic
Actions

Authored by cse_cem_gmail_com on Apr 27 2015, 10:05 PM.

Tags

None

Referenced Files

	F122809115: D2381.id5044.diff
	Tue, Jul 8, 11:20 AM

	Unknown Object (File)
	Mon, Jul 7, 5:00 PM

	Unknown Object (File)
	Sat, Jul 5, 2:27 AM

	Unknown Object (File)
	Fri, Jun 27, 12:25 AM

	Unknown Object (File)
	Tue, Jun 24, 12:32 AM

	Unknown Object (File)
	Wed, Jun 18, 3:00 AM

	Unknown Object (File)
	Sun, Jun 15, 2:59 PM

	Unknown Object (File)
	May 29 2025, 1:52 AM

View All 88 Files

Subscribers

Details

Reviewers

kib
benno
emaste

Group Reviewers

Summary

We can't use MAP_ENTRY_IN_TRANSITION / vm_map_unlock_and_wait when we
have a vnode lock held, because it can deadlock as vm_map_wire tries to
fault it in.

Bug discovered by Peter Holm (mmap7 / mmap7a from stress2).

Patch suggested by Attilio Rao.

Test Plan

Run mmap7a test; before this patch, the machine eventually deadlocks.
Characteristically, one thread will be waiting on "vmmaps" and at least one
other thread on "ufs".

After this patch, mmap7a no longer causes this deadlock.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

cse_cem_gmail_com updated this revision to Diff 5044.Apr 27 2015, 10:05 PM

cse_cem_gmail_com retitled this revision from to vm_fault: Fix deadlock between vm_map_wire and vm_fault_hold.

cse_cem_gmail_com updated this object.

cse_cem_gmail_com edited the test plan for this revision. (Show Details)

cse_cem_gmail_com added reviewers: benno, kib, emaste.

Herald added a reviewer: manpages. · View Herald TranscriptApr 27 2015, 10:05 PM

Herald added a subscriber: imp. · View Herald Transcript

benno accepted this revision.Apr 28 2015, 11:45 PM

benno edited edge metadata.

This revision is now accepted and ready to land.Apr 28 2015, 11:45 PM

Committed by @kostikbel in r282128.

Revision Contents
Changeset List

Path

Size

sys/

vm/

4 lines

Diff 5044

sys/vm/vm_fault.c

Loading...