Page MenuHomeFreeBSD
Differential D17626

Add an assertion to pmap_enter().
ClosedPublic
Actions

Authored by markj on Oct 20 2018, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 5:51 AM
Unknown Object (File)
Feb 28 2025, 12:12 PM
Unknown Object (File)
Feb 23 2025, 12:30 AM
Unknown Object (File)
Feb 20 2025, 5:56 PM
Unknown Object (File)
Feb 6 2025, 4:52 AM
Unknown Object (File)
Jan 14 2025, 3:18 AM
Unknown Object (File)
Jan 9 2025, 5:28 AM
Unknown Object (File)
Dec 28 2024, 6:58 PM
View All 51 Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rS339490: Add an assertion to pmap_enter().
Summary

When faulting on an existing mapping, if the mapping is managed, it
should have a PV entry. Verify this.

I found this useful while debugging some modifications.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Oct 20 2018, 8:03 PM
Harbormaster completed remote builds in B20308: Diff 49350.Oct 20 2018, 8:03 PM
markj added reviewers: alc, kib.Oct 20 2018, 8:05 PM
alc added inline comments.Oct 20 2018, 8:12 PM
sys/amd64/amd64/pmap.c
5063 ↗(On Diff #49350)

Based on line 5047, (origpte & PG_MANAGED) == 0 can never be true.

markj updated this revision to Diff 49353.Oct 20 2018, 8:21 PM
markj marked 2 inline comments as done.
  • Address Alan's comment.
Harbormaster completed remote builds in B20309: Diff 49353.Oct 20 2018, 8:21 PM
markj added inline comments.Oct 20 2018, 8:21 PM
sys/amd64/amd64/pmap.c
5063 ↗(On Diff #49350)

Thanks, I originally had this assertion further down.

kib accepted this revision.Oct 20 2018, 8:25 PM
This revision is now accepted and ready to land.Oct 20 2018, 8:25 PM
alc accepted this revision.Oct 20 2018, 8:27 PM
Closed by commit rS339490: Add an assertion to pmap_enter(). (authored by markj). · Explain WhyOct 20 2018, 8:53 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 8:53 PM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines
i386/
i386/
2 lines

Diff 49357

View Options

head/sys/amd64/amd64/pmap.c

Show All 16 Lines
char *itoa7(int); char *itoa7(int);
int digits(int); int digits(int);
const char * const *argparse(char *, int *); const char * const *argparse(char *, int *);
long percentages(int, int *, long *, long *, long *); long percentages(int, int *, long *, long *, long *);
const char *format_time(long); const char *format_time(long);
char *format_k(int64_t); char *format_k(int64_t);
int string_index(const char *string, const char * const *array); int string_index(const char *string, const char * const *array);
int find_pid(pid_t pid); int find_pid(pid_t pid);
int utf8strvisx(char *, const char *, size_t);
View Options

head/sys/i386/i386/pmap.c

Show All 16 Lines
char *itoa7(int); char *itoa7(int);
int digits(int); int digits(int);
const char * const *argparse(char *, int *); const char * const *argparse(char *, int *);
long percentages(int, int *, long *, long *, long *); long percentages(int, int *, long *, long *, long *);
const char *format_time(long); const char *format_time(long);
char *format_k(int64_t); char *format_k(int64_t);
int string_index(const char *string, const char * const *array); int string_index(const char *string, const char * const *array);
int find_pid(pid_t pid); int find_pid(pid_t pid);
int utf8strvisx(char *, const char *, size_t);